Attention is currently required from: Arthur Heymans, Chen, Gang C, Christian Walter, Jincheng Li, Johnny Lin, Tim Chu.
Shuo Liu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78332?usp=email )
Change subject: soc/intel/xeon_sp: Scan and allocate resources on all stacks ......................................................................
Patch Set 13:
(3 comments)
File src/soc/intel/xeon_sp/acpi.c:
https://review.coreboot.org/c/coreboot/+/78332/comment/e6cac989_3660c5fd : PS13, Line 108: if (ioapic_base == 0) the SPR HOB returns ineffective IOAPIC range as 0xFFFFFFFF..0x00000000 and here an update is needed accordingly
File src/soc/intel/xeon_sp/chip_common.c:
https://review.coreboot.org/c/coreboot/+/78332/comment/8df364d1_71a80476 : PS13, Line 112: if (ri->BusBase < ri->BusLimit) a fixes is needed: ri->BusBase > ri->BusLimit
File src/soc/intel/xeon_sp/util.c:
https://review.coreboot.org/c/coreboot/+/78332/comment/00c4343c_b81eba13 : PS12, Line 118: if (!is_pcie_iio_stack_res(ri))
Should we remove ln 118 so that all stack info will be returned? […]
From CPX semantics point of view, stack_needs_resource_alloc equals to is_pcie_iio_stack_res, but from the API semantics point of view, get_iiostack_info are not restricted to return PCIe IIO stack only. Maybe we could move this API as CPX only.