Attention is currently required from: Henry Sun, Super Ni, Teddy Shih, Simon Yang, Aseda Aboagye, Ivan Chen, Karthik Ramasubramanian.
Teddy Shih has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63652 )
Change subject: mb/google/dedede/var/beadrix: Add a Proximity Sensor SX9324 for SAR
......................................................................
Patch Set 3: Code-Review+1
(3 comments)
Patchset:
PS2:
hi Teddy, trivial or not, is it possible to get ECS to share power related impact thereafter?
Hi Super,
I have requested ECS to applying this CL to measure poower consumption and inspect any power related impact. Once receving ECS results, I will update it.
Patchset:
PS3:
Dear All,
I have replied reviewers' comments and requested ECS to measure power related impact. Please reviewers review my CL.
Best Regards,
Teddy
File src/mainboard/google/dedede/variants/beadrix/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/63652/comment/e936dfc5_72a3bb65
PS2, Line 139: chip drivers/i2c/sx9324
According to src/drivers/i2c/sx9324/sx9324. […]
Hi Simon,
Thank you for your advice.
As I have studies the ACPI spec. revision 5.1 of 6.1.12 _UID (Unique ID)(https://uefi.org/sites/default/files/resources/ACPI_5_1release.pdf) and refer to other prjoect code's uid definition (https://review.coreboot.org/plugins/gitiles/coreboot/+/14a1c2778fda7e4ed25d6...), I will add a uid define starting from 0.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63652
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If172d13aa62503547227adf91f049ea50b948888
Gerrit-Change-Number: 63652
Gerrit-PatchSet: 3
Gerrit-Owner: Teddy Shih
teddyshih@ami.corp-partner.google.com
Gerrit-Reviewer: Aseda Aboagye
aaboagye@google.com
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: Ivan Chen
yulunchen@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Simon Yang
simon1.yang@intel.corp-partner.google.com
Gerrit-Reviewer: Super Ni
super.ni@intel.corp-partner.google.com
Gerrit-Reviewer: Teddy Shih
teddyshih@ami.corp-partner.google.com
Gerrit-Reviewer: Teddy Shih
teddyshihau@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Eddy Lu
eddylu@ami.corp-partner.google.com
Gerrit-CC: Jack Cheng
jack.cheng@ecs.corp-partner.google.com
Gerrit-CC: Raymond Chung
raymondchung@ami.corp-partner.google.com
Gerrit-CC: Simon Yang
simon1.yang@intel.com
Gerrit-Attention: Henry Sun
henrysun@google.com
Gerrit-Attention: Super Ni
super.ni@intel.corp-partner.google.com
Gerrit-Attention: Teddy Shih
teddyshihau@gmail.com
Gerrit-Attention: Simon Yang
simon1.yang@intel.com
Gerrit-Attention: Aseda Aboagye
aaboagye@google.com
Gerrit-Attention: Simon Yang
simon1.yang@intel.corp-partner.google.com
Gerrit-Attention: Ivan Chen
yulunchen@google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Wed, 20 Apr 2022 07:23:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Super Ni
super.ni@intel.corp-partner.google.com
Comment-In-Reply-To: Simon Yang
simon1.yang@intel.com
Gerrit-MessageType: comment