Attention is currently required from: Philipp Hug, ron minnich.
Alper Nebi Yasak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80363?usp=email )
Change subject: mainboard/qemu-riscv: Get top of memory from device-tree blob ......................................................................
Patch Set 2:
(1 comment)
File src/soc/ucb/riscv/cbmem.c:
https://review.coreboot.org/c/coreboot/+/80363/comment/ebba1a94_11677fc4 : PS2, Line 13: top = fdt_get_memory_top((void *)HLS()->fdt); Breaks mb/spike-riscv build. I don't have any experience with it so don't know what best to do, thinking of one of:
- Select FLATTENED_DEVICE_TREE also for spike-riscv (would it work?) - Use `if (CONFIG(FLATTENED_DEVICE_TREE))` - Add custom `cbmem.c` to mb/spike-riscv without this - Add custom `cbmem.c` to mb/qemu-riscv for this
(It also appears to hardcode a 1GiB RAM size in its `mainboard.c`)