Paul Fagerburg has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45739 )
Change subject: lib/Makefile.inc: fix name of config string ......................................................................
lib/Makefile.inc: fix name of config string
The config string is HAVE_SPD_IN_CBFS, without the "BIN".
Signed-off-by: Paul Fagerburg pfagerburg@google.com Change-Id: I728f64b2dd93b0e3947983b9b3701e185feff571 --- M src/lib/Makefile.inc 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/45739/1
diff --git a/src/lib/Makefile.inc b/src/lib/Makefile.inc index 73077f7..ce57f51 100644 --- a/src/lib/Makefile.inc +++ b/src/lib/Makefile.inc @@ -358,7 +358,7 @@ # Include spd ROM data $(LIB_SPD_BIN): $(LIB_SPD_DEPS) test -n "$(SPD_SOURCES)" || \ - (echo "HAVE_SPD_BIN_IN_CBFS is set but SPD_SOURCES is empty" && exit 1) + (echo "HAVE_SPD_IN_CBFS is set but SPD_SOURCES is empty" && exit 1) test -n "$(LIB_SPD_DEPS)" || \ (echo "SPD_SOURCES is set but no SPD file was found" && exit 1) for f in $(LIB_SPD_DEPS); \
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45739 )
Change subject: lib/Makefile.inc: fix name of config string ......................................................................
Patch Set 1: Code-Review+2
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45739 )
Change subject: lib/Makefile.inc: fix name of config string ......................................................................
Patch Set 1: Code-Review+2
Thank you!
Paul Fagerburg has submitted this change. ( https://review.coreboot.org/c/coreboot/+/45739 )
Change subject: lib/Makefile.inc: fix name of config string ......................................................................
lib/Makefile.inc: fix name of config string
The config string is HAVE_SPD_IN_CBFS, without the "BIN".
Signed-off-by: Paul Fagerburg pfagerburg@google.com Change-Id: I728f64b2dd93b0e3947983b9b3701e185feff571 Reviewed-on: https://review.coreboot.org/c/coreboot/+/45739 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Furquan Shaikh furquan@google.com Reviewed-by: Michael Niewöhner foss@mniewoehner.de --- M src/lib/Makefile.inc 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved Michael Niewöhner: Looks good to me, approved
diff --git a/src/lib/Makefile.inc b/src/lib/Makefile.inc index 73077f7..ce57f51 100644 --- a/src/lib/Makefile.inc +++ b/src/lib/Makefile.inc @@ -358,7 +358,7 @@ # Include spd ROM data $(LIB_SPD_BIN): $(LIB_SPD_DEPS) test -n "$(SPD_SOURCES)" || \ - (echo "HAVE_SPD_BIN_IN_CBFS is set but SPD_SOURCES is empty" && exit 1) + (echo "HAVE_SPD_IN_CBFS is set but SPD_SOURCES is empty" && exit 1) test -n "$(LIB_SPD_DEPS)" || \ (echo "SPD_SOURCES is set but no SPD file was found" && exit 1) for f in $(LIB_SPD_DEPS); \
-
Furquan Shaikh (Code Review) -
Michael Niewöhner (Code Review)
-
Paul Fagerburg (Code Review)