Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36596 )
Change subject: include: introduce update* for mmio operations ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36596/2/src/include/mmio.h File src/include/mmio.h:
https://review.coreboot.org/c/coreboot/+/36596/2/src/include/mmio.h@13 PS2, Line 13:
Should we allow users to expect the indirect inclusion of `arch/mmio.h`? […]
Well, this is not the best example. We know that it makes no sense to implemented update*() differently. But generally, when an implementation would change, indirect includes can break. Hence, one shouldn't make assumptions about them unless there is a clear definition... like "mmio.h provides read/write*()".
Also, I wrote this mostly because I know some folks try to keep includes clean. And a comment here could save us any future discussion about it :)