Change in coreboot[master]: mainboard/ocp: Use SPDX for GPL-2.0-only files

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Angel Pons (Code Review)

2 Apr 2020 2 Apr '20

11:26 p.m.

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/40088 )

Change subject: mainboard/ocp: Use SPDX for GPL-2.0-only files ......................................................................

mainboard/ocp: Use SPDX for GPL-2.0-only files

Done with sed and God Lines. Only done for C-like code for now.

Change-Id: I136e19fbba22b71676a0163a88ae341356c31271 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/ocp/tiogapass/acpi_tables.c 1 file changed, 1 insertion(+), 11 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/40088/1

diff --git a/src/mainboard/ocp/tiogapass/acpi_tables.c b/src/mainboard/ocp/tiogapass/acpi_tables.c index 76778a9..1bba877 100644 --- a/src/mainboard/ocp/tiogapass/acpi_tables.c +++ b/src/mainboard/ocp/tiogapass/acpi_tables.c @@ -1,16 +1,6 @@ /* * This file is part of the coreboot project. - * - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; version 2 of the License. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * + * SPDX-License-Identifier: GPL-2.0-only * */

#include <intelblocks/acpi.h>

Attachments:

attachment.htm (text/html — 3.3 KB)

Show replies by date

HAOUAS Elyes (Code Review)

4 Apr 4 Apr

4:22 p.m.

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40088 )

Change subject: mainboard/ocp: Use SPDX for GPL-2.0-only files ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/40088/2/src/mainboard/ocp/tiogapass... File src/mainboard/ocp/tiogapass/acpi_tables.c:

https://review.coreboot.org/c/coreboot/+/40088/2/src/mainboard/ocp/tiogapass... PS2, Line 5: /* SPDX-License-Identifier: GPL-2.0-only */ /* This file is part of the coreboot project. */

-- To view, visit https://review.coreboot.org/c/coreboot/+/40088 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I136e19fbba22b71676a0163a88ae341356c31271 Gerrit-Change-Number: 40088 Gerrit-PatchSet: 2 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: HAOUAS Elyes ehaouas@noos.fr Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Sat, 04 Apr 2020 16:22:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Angel Pons (Code Review)

4:37 p.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40088 )

Change subject: mainboard/ocp: Use SPDX for GPL-2.0-only files ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/40088/2/src/mainboard/ocp/tiogapass... File src/mainboard/ocp/tiogapass/acpi_tables.c:

https://review.coreboot.org/c/coreboot/+/40088/2/src/mainboard/ocp/tiogapass... PS2, Line 5:

...

/* SPDX-License-Identifier: GPL-2.0-only */ […]

Escaped my sed-fu due to the empty comment line. Will fix.

-- To view, visit https://review.coreboot.org/c/coreboot/+/40088 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I136e19fbba22b71676a0163a88ae341356c31271 Gerrit-Change-Number: 40088 Gerrit-PatchSet: 2 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: HAOUAS Elyes ehaouas@noos.fr Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Sat, 04 Apr 2020 16:37:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: HAOUAS Elyes ehaouas@noos.fr Gerrit-MessageType: comment

Angel Pons (Code Review)

10:45 p.m.

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/40088

to look at the new patch set (#3).

Change subject: mainboard/ocp: Use SPDX for GPL-2.0-only files ......................................................................

mainboard/ocp: Use SPDX for GPL-2.0-only files

Done with sed and God Lines. Only done for C-like code for now.

Change-Id: I136e19fbba22b71676a0163a88ae341356c31271 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/ocp/tiogapass/acpi_tables.c 1 file changed, 2 insertions(+), 14 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/40088/3

-- To view, visit https://review.coreboot.org/c/coreboot/+/40088 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I136e19fbba22b71676a0163a88ae341356c31271 Gerrit-Change-Number: 40088 Gerrit-PatchSet: 3 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: HAOUAS Elyes ehaouas@noos.fr Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Angel Pons (Code Review)

10:45 p.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40088 )

Change subject: mainboard/ocp: Use SPDX for GPL-2.0-only files ......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/40088/2/src/mainboard/ocp/tiogapass... File src/mainboard/ocp/tiogapass/acpi_tables.c:

https://review.coreboot.org/c/coreboot/+/40088/2/src/mainboard/ocp/tiogapass... PS2, Line 5:

...

Escaped my sed-fu due to the empty comment line. Will fix.

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/40088 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I136e19fbba22b71676a0163a88ae341356c31271 Gerrit-Change-Number: 40088 Gerrit-PatchSet: 3 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: HAOUAS Elyes ehaouas@noos.fr Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Sat, 04 Apr 2020 22:45:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com Comment-In-Reply-To: HAOUAS Elyes ehaouas@noos.fr Gerrit-MessageType: comment

Felix Held (Code Review)

11:26 p.m.

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40088 )

Change subject: mainboard/ocp: Use SPDX for GPL-2.0-only files ......................................................................

Patch Set 3: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/40088 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I136e19fbba22b71676a0163a88ae341356c31271 Gerrit-Change-Number: 40088 Gerrit-PatchSet: 3 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: HAOUAS Elyes ehaouas@noos.fr Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Sat, 04 Apr 2020 23:26:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Felix Held (Code Review)

6 Apr 6 Apr

1:39 p.m.

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/40088 )

Change subject: mainboard/ocp: Use SPDX for GPL-2.0-only files ......................................................................

mainboard/ocp: Use SPDX for GPL-2.0-only files

Done with sed and God Lines. Only done for C-like code for now.

Change-Id: I136e19fbba22b71676a0163a88ae341356c31271 Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/40088 Reviewed-by: Felix Held felix-coreboot@felixheld.de Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/ocp/tiogapass/acpi_tables.c 1 file changed, 2 insertions(+), 14 deletions(-)

Approvals: build bot (Jenkins): Verified Felix Held: Looks good to me, approved

diff --git a/src/mainboard/ocp/tiogapass/acpi_tables.c b/src/mainboard/ocp/tiogapass/acpi_tables.c index 76778a9..1da4f8e 100644 --- a/src/mainboard/ocp/tiogapass/acpi_tables.c +++ b/src/mainboard/ocp/tiogapass/acpi_tables.c @@ -1,17 +1,5 @@ -/* - * This file is part of the coreboot project. - * - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; version 2 of the License. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - */ +/* SPDX-License-Identifier: GPL-2.0-only */ +/* This file is part of the coreboot project. */

#include <intelblocks/acpi.h> #include <soc/acpi.h>

-- To view, visit https://review.coreboot.org/c/coreboot/+/40088 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I136e19fbba22b71676a0163a88ae341356c31271 Gerrit-Change-Number: 40088 Gerrit-PatchSet: 4 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: HAOUAS Elyes ehaouas@noos.fr Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

1487

days inactive

1491

days old

coreboot-gerrit@coreboot.org

6 comments

3 participants

tags (0)

participants (3)

Angel Pons (Code Review)
Felix Held (Code Review)
HAOUAS Elyes (Code Review)