Hello Varshit B Pandya, build bot (Jenkins), Matt Delco, Furquan Shaikh, Tim Wawrzynczak, Rizwan Qureshi, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/43003
to look at the new patch set (#11).
Change subject: drivers/intel/mipi_camera: Add guard to protect camera resources ......................................................................
drivers/intel/mipi_camera: Add guard to protect camera resources
This change updates the mipi_camera driver to handle shared power resource between multiple cameras. This is achieved by adding a guard variable and methods to manipulate the guard variable before calling the actual platform method which enables or disables the resource. PowerResource will call these guarded methods to enable or disable the resource. This protects the shared resource from being enabled or disabled multiple times while the other camera is using the resource.
Example: Consider a platform where two cameras are sharing a GPIO resource 0xXX and both the cameras calls enable and disable guarded methods for this GPIO. Actual platform disable method for the GPIO is called only after the last camera using the GPIO calls DSBx method and RESx becomes 0.
Scope (_SB.PCI0) { Name (RESx, Zero) Method (ENBx, 0, Serialized) { If ((RESx == Zero)) { _SB.PCI0.STXS (0xXX) }
RESx++ }
Method (DSBx, 0, Serialized) { If ((RESx > Zero)) { RESx-- }
If ((RESx == Zero)) { _SB.PCI0.CTXS (0xXX) } } }
Change-Id: I1468459d5bbb2fb07bef4e0590c96dd4dbab0d9c Signed-off-by: Sugnan Prabhu S sugnan.prabhu.s@intel.com --- M src/drivers/intel/mipi_camera/camera.c M src/drivers/intel/mipi_camera/chip.h 2 files changed, 353 insertions(+), 40 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/43003/11