Change in coreboot[master]: cbfstool: Do host space address conversion earlier when adding files

[Julius Werner (Code Review)]

Attention is currently required from: Raul Rangel, Patrick Georgi, Tim Wawrzynczak.
Hello Raul Rangel, Patrick Georgi, Tim Wawrzynczak,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/60018

to look at the new patch set (#2).

Change subject: cbfstool: Do host space address conversion earlier when adding files
......................................................................

cbfstool: Do host space address conversion earlier when adding files

A simple code simplification where we can pull the call to
convert_addr_space() in cbfs_add_component() earlier, so that we can
avoid having to duplicate it in cbfstool_convert_fsp(). Host space
addresses in this function can only occur if the user manually provided
them via the --base-address flag -- all other functions (e.g.
do_cbfs_locate()) already work in the flash address space anyway. This
should also fix a tiny issue where --gen-attribute might have previously
encoded the address as given in CBFS -- it probably makes more sense to
always have it store a consistent format (i.e. always flash address).

Also revert the unnecessary check for --base-address in
add_topswap_bootblock(). On closer inspection, the function actually
doesn't use the passed in *offset at all and uses it purely as an
out-parameter. So while our current Makefile does pass --base-address
when adding the bootblock, it actually has no effect and is redundant
for the topswap case.

Signed-off-by: Julius Werner 
Change-Id: Idf4721c5b0700789ddb81c1618d740b3e7f486cb
---
M util/cbfstool/cbfstool.c
1 file changed, 9 insertions(+), 22 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/60018/2