Attention is currently required from: Furquan Shaikh, Martin Roth, Michał Żygowski, Marshall Dawson, Subrata Banik, Andrey Petrov, Patrick Rudolph, Nathaniel L Desimone. Nikolai Vyssotski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56190 )
Change subject: src/drivers/intel/fsp2_0: allow larger FSP 2.0 header ......................................................................
Patch Set 5:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56190/comment/e815060b_3c3727e0 PS4, Line 12: This field is not used in coreboot yet.
This is not really correct. It is used by some Intel platforms.
Done
https://review.coreboot.org/c/coreboot/+/56190/comment/0d6a6baa_a756743a PS4, Line 13: Allow headers of both lengths to be accepted.
Can you please add the detail that the check for header length in `looks_like_fsp_header()` is updat […]
Done
File src/drivers/intel/fsp2_0/util.c:
https://review.coreboot.org/c/coreboot/+/56190/comment/5a2c71ce_bd565211 PS3, Line 14: looks_like_fsp_header
I believe its kind of yes and no IMHO. […]
Ack
File src/drivers/intel/fsp2_0/util.c:
https://review.coreboot.org/c/coreboot/+/56190/comment/177066b7_3c986bdc PS4, Line 17: if (CONFIG(PLATFORM_USES_FSP2_2))
please, no spaces at the start of a line […]
Done
https://review.coreboot.org/c/coreboot/+/56190/comment/584d368f_dc60b622 PS4, Line 36: fsp_header_length < fsp_hdr_get_expected_min_length()
Can you please add a comment here explaining why header length is compared against a minimum value f […]
Done
-
Nikolai Vyssotski (Code Review)