Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33826 )
Change subject: mb/google/hatch/variants/helios: Update GPIO table for proto stage ......................................................................
Patch Set 3:
(4 comments)
https://review.coreboot.org/c/coreboot/+/33826/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/33826/3//COMMIT_MSG@12 PS3, Line 12: BRANCH=Master not required for master branch.
https://review.coreboot.org/c/coreboot/+/33826/3/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/helios/gpio.c:
https://review.coreboot.org/c/coreboot/+/33826/3/src/mainboard/google/hatch/... PS3, Line 42: /* C11 : GPP_C11 ==> EN_PP3300_PP1800_FP */ : PAD_CFG_GPO(GPP_C11, 0, DEEP), This is already done in baseboard/gpio.c for hatch, right?
https://review.coreboot.org/c/coreboot/+/33826/3/src/mainboard/google/hatch/... PS3, Line 56: /* D9 : GPP_D9 ==> EN_PP3300_TOUCHSCREEN_DX */ : PAD_CFG_GPO(GPP_D9, 0, DEEP), This is being added to baseboard here: https://review.coreboot.org/c/coreboot/+/33808/4/src/mainboard/google/hatch/...
https://review.coreboot.org/c/coreboot/+/33826/3/src/mainboard/google/hatch/... PS3, Line 101: 1 Shouldn't this be done as part of ACPI to ensure timing requirements are met?