Change in coreboot[master]: soc/mediatek/mt8192: Add dramc param struct - coreboot-gerrit

19 Aug 2020

Hello Duan huayang,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/44566
to review the following change.
Change subject: soc/mediatek/mt8192: Add dramc param struct
......................................................................
soc/mediatek/mt8192: Add dramc param struct
Signed-off-by: Huayang Duan huayang.duan@mediatek.com
Change-Id: I3bae57e6777ab6fc46c771a034f814dd1175be95
---
A src/soc/mediatek/mt8192/dramc_param.c
A src/soc/mediatek/mt8192/include/soc/dramc_common_mt8192.h
A src/soc/mediatek/mt8192/include/soc/dramc_param.h
3 files changed, 294 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/66/44566/1

diff --git a/src/soc/mediatek/mt8192/dramc_param.c b/src/soc/mediatek/mt8192/dramc_param.c
new file mode 100644
index 0000000..f8f6c7d
--- /dev/null
+++ b/src/soc/mediatek/mt8192/dramc_param.c
@@ -0,0 +1,56 @@
+/* SPDX-License-Identifier: GPL-2.0-only */
+
+#include <console/console.h>
+#include <string.h>
+#include <soc/dramc_param.h>
+
+#define print(_x_...) printk(BIOS_INFO, _x_)
+
+struct dramc_param *get_dramc_param_from_blob(void *blob)
+{
+	return (struct dramc_param *)blob;
+}
+
+void dump_param_header(const void *blob)
+{
+	const struct dramc_param *dparam = blob;
+	const struct dramc_param_header *header = &dparam->header;
+
+	print("header.status = %#x\n", header->status);
+	print("header.version = %#x (expected: %#x)\n",
+	       header->version, DRAMC_PARAM_HEADER_VERSION);
+	print("header.size = %#x (expected: %#lx)\n",
+	       header->size, sizeof(*dparam));
+	print("header.flags = %#x\n", header->flags);
+	print("header.checksum = %#x\n", header->checksum);
+}
+
+int validate_dramc_param(const void *blob)
+{
+	const struct dramc_param *param = blob;
+	const struct dramc_param_header *hdr = &param->header;
+
+	if (hdr->version != DRAMC_PARAM_HEADER_VERSION)
+		return DRAMC_ERR_INVALID_VERSION;
+
+	if (hdr->size != sizeof(*param))
+		return DRAMC_ERR_INVALID_SIZE;
+
+	return DRAMC_SUCCESS;
+}
+
+int is_valid_dramc_param(const void *blob)
+{
+	return validate_dramc_param(blob) == DRAMC_SUCCESS;
+}
+
+int initialize_dramc_param(void *blob)
+{
+	struct dramc_param *param = blob;
+	struct dramc_param_header *hdr = &param->header;
+
+	memset(hdr, 0, sizeof(*hdr));
+	hdr->version = DRAMC_PARAM_HEADER_VERSION;
+	hdr->size = sizeof(*param);
+	return 0;
+}
diff --git a/src/soc/mediatek/mt8192/include/soc/dramc_common_mt8192.h b/src/soc/mediatek/mt8192/include/soc/dramc_common_mt8192.h
new file mode 100644
index 0000000..e058a1c
--- /dev/null
+++ b/src/soc/mediatek/mt8192/include/soc/dramc_common_mt8192.h
@@ -0,0 +1,82 @@
+/* SPDX-License-Identifier: GPL-2.0-only */
+
+#ifndef __SOC_MEDIATEK_MT8192_DRAMC_COMMON_MT8192_H__
+#define __SOC_MEDIATEK_MT8192_DRAMC_COMMON_MT8192_H__
+
+enum {
+	CHANNEL_A = 0,
+	CHANNEL_B,
+	CHANNEL_MAX
+};
+
+enum {
+	RANK_0= 0,
+	RANK_1,
+	RANK_MAX
+};
+
+enum {
+	FSP_0 = 0,
+	FSP_1,
+	FSP_MAX,
+};
+
+typedef enum {
+	DRAM_DFS_SHU0 = 0,
+	DRAM_DFS_SHU1,
+	DRAM_DFS_SHU2,
+	DRAM_DFS_SHU3,
+	DRAM_DFS_SHU4,
+	DRAM_DFS_SHU5,
+	DRAM_DFS_SHU6,
+	DRAM_DFS_SHU_MAX
+} dram_dfs_shu;
+
+typedef enum {
+	ODT_OFF = 0,
+	ODT_ON,
+	ODT_MAX
+} dram_odt_state;
+
+typedef enum {
+	DBI_OFF = 0,
+	DBI_ON
+} dbi_mode;
+
+enum {
+	CKE_FIXOFF = 0,
+	CKE_FIXON,
+	CKE_DYNAMIC
+};
+
+enum {
+	CA_NUM_LP4 = 6,
+	DQ_DATA_WIDTH = 16,
+	DQS_BIT_NUMBER = 8,
+	DQS_NUMBER = (DQ_DATA_WIDTH / DQS_BIT_NUMBER),
+};
+#define BYTE_NUM		DQS_NUMBER
+#define DQS_NUMBER_LP4		DQS_NUMBER
+#define DQ_DATA_WIDTH_LP4	DQ_DATA_WIDTH
+
+typedef enum {
+	CBT_NORMAL_MODE = 0,
+	CBT_BYTE_MODE1
+} dram_cbt_mode;
+
+/* DONOT change the sequence of pinmux */
+typedef enum {
+	PINMUX_DSC = 0,
+	PINMUX_LPBK,
+	PINMUX_EMCP,
+	PINMUX_MAX
+} dram_pinmux_type;
+
+enum {
+	CBT_R0_R1_NORMAL = 0,
+	CBT_R0_R1_BYTE,
+	CBT_R0_NORMAL_R1_BYTE,
+	CBT_R0_BYTE_R1_NORMAL
+};
+
+#endif	/* __SOC_MEDIATEK_MT8192_DRAMC_COMMON_MT8192_H__ */
diff --git a/src/soc/mediatek/mt8192/include/soc/dramc_param.h b/src/soc/mediatek/mt8192/include/soc/dramc_param.h
new file mode 100644
index 0000000..89ff628
--- /dev/null
+++ b/src/soc/mediatek/mt8192/include/soc/dramc_param.h
@@ -0,0 +1,156 @@
+/* SPDX-License-Identifier: GPL-2.0-only */
+
+#ifndef __SOC_MEDIATEK_MT8192_DRAMC_PARAM_H__
+#define __SOC_MEDIATEK_MT8192_DRAMC_PARAM_H__
+
+#include <stdint.h>
+#include <sys/types.h>
+#include <soc/dramc_common_mt8192.h>
+
+enum {
+	DRAMC_PARAM_HEADER_VERSION = 2,
+};
+
+enum DRAMC_PARAM_STATUS_CODES {
+	DRAMC_SUCCESS = 0,
+	DRAMC_ERR_INVALID_VERSION,
+	DRAMC_ERR_INVALID_SIZE,
+	DRAMC_ERR_INVALID_CHECKSUM,
+	DRAMC_ERR_INVALID_FLAGS,
+	DRAMC_ERR_RECALIBRATE,
+	DRAMC_ERR_INIT_DRAM,
+	DRAMC_ERR_COMPLEX_RW_MEM_TEST,
+	DRAMC_ERR_1ST_COMPLEX_RW_MEM_TEST,
+	DRAMC_ERR_2ND_COMPLEX_RW_MEM_TEST,
+	DRAMC_ERR_FAST_CALIBRATION,
+};
+
+enum DRAMC_PARAM_DVFS_FLAG {
+	DRAMC_DISABLE_DVFS,
+	DRAMC_ENABLE_DVFS,
+};
+
+enum DRAMC_PARAM_FLAGS {
+	DRAMC_FLAG_HAS_SAVED_DATA = 0x0001,
+};
+
+enum DRAMC_PARAM_DDR_TYPE {
+	DDR_TYPE_DISCRETE,
+	DDR_TYPE_EMCP,
+};
+
+enum DRAMC_PARAM_GEOMETRY_TYPE {
+	DDR_TYPE_2CH_2RK_4GB_2_2,
+	DDR_TYPE_2CH_2RK_6GB_3_3,
+	DDR_TYPE_2CH_2RK_8GB_4_4,
+	DDR_TYPE_2CH_1RK_4GB_4_0,
+	DDR_TYPE_2CH_2RK_6GB_2_4,
+};
+
+enum DRAM_PARAM_VOLTAGE_TYPE {
+	DRAM_VOLTAGE_NVCORE_NVDRAM,
+	DRAM_VOLTAGE_HVCORE_HVDRAM,
+	DRAM_VOLTAGE_LVCORE_LVDRAM,
+};
+
+struct dramc_param_header {
+	u32 checksum;	/* checksum of dramc_datas, update in the coreboot */
+	u16 version;	/* DRAMC_PARAM_HEADER_VERSION, update in the coreboot */
+	u16 size;	/* size of whole dramc_param, update in the coreboot */
+	u16 status;	/* DRAMC_PARAM_STATUS_CODES, update in the dram blob */
+	u16 flags;	/* DRAMC_PARAM_FLAGS, update in the dram blob */
+};
+
+struct sdram_params {
+	u32 rank_num;
+	u16 num_dlycell_perT;
+	u16 delay_cell_timex100;
+
+	/* duty */
+	s8 duty_clk_delay[CHANNEL_MAX][RANK_MAX];
+	s8 duty_dqs_delay[CHANNEL_MAX][DQS_NUMBER_LP4];
+	s8 duty_wck_delay[CHANNEL_MAX][DQS_NUMBER_LP4];
+	s8 duty_dq_delay[CHANNEL_MAX][DQS_NUMBER_LP4];
+	s8 duty_dqm_delay[CHANNEL_MAX][DQS_NUMBER_LP4];
+
+	/* CBT */
+	u8 cbt_final_vref[CHANNEL_MAX][RANK_MAX];
+	s8 cbt_cmd_dly[CHANNEL_MAX][RANK_MAX];
+	u8 cbt_cs_dly[CHANNEL_MAX][RANK_MAX];
+	u8 cbt_ca_prebit_dly[CHANNEL_MAX][RANK_MAX][DQS_BIT_NUMBER];
+
+	/* write leveling */
+	u8 wr_level[CHANNEL_MAX][RANK_MAX][DQS_NUMBER_LP4];
+
+	/* Gating */
+	u8 gating_MCK[CHANNEL_MAX][RANK_MAX][DQS_NUMBER_LP4];
+	u8 gating_UI[CHANNEL_MAX][RANK_MAX][DQS_NUMBER_LP4];
+	u8 gating_PI[CHANNEL_MAX][RANK_MAX][DQS_NUMBER_LP4];
+	u8 gating_pass_count[CHANNEL_MAX][RANK_MAX][DQS_NUMBER_LP4];
+
+	/* TX perbit */
+	u8 tx_window_vref[CHANNEL_MAX][RANK_MAX];
+	u16 tx_center_min[CHANNEL_MAX][RANK_MAX][DQS_NUMBER_LP4];
+	u16 tx_center_max[CHANNEL_MAX][RANK_MAX][DQS_NUMBER_LP4];
+	u16 tx_win_center[CHANNEL_MAX][RANK_MAX][DQ_DATA_WIDTH_LP4];
+
+	/* rx datlat */
+	u8 rx_datlat[CHANNEL_MAX][RANK_MAX];
+
+	/* RX perbit */
+	u8 rx_best_vref[CHANNEL_MAX][RANK_MAX][DQS_NUMBER_LP4];
+	u16 rx_perbit_dqs[CHANNEL_MAX][RANK_MAX][DQS_NUMBER_LP4];
+	u16 rx_perbit_dqm[CHANNEL_MAX][RANK_MAX][DQS_NUMBER_LP4];
+	u16 rx_perbit_dq[CHANNEL_MAX][RANK_MAX][DQ_DATA_WIDTH_LP4];
+
+	/* TX OE */
+	u8 tx_oe_dq_mck[CHANNEL_MAX][RANK_MAX][DQS_NUMBER_LP4];
+	u8 tx_oe_dq_ui[CHANNEL_MAX][RANK_MAX][DQS_NUMBER_LP4];
+};
+
+struct emi_mdl {
+	u32 cona_val;
+	u32 conh_val;
+	u32 conf_val;
+	u32 chn_cona_val;
+};
+
+struct ddr_base_info {
+	u16 config_dvfs;		/* DRAMC_PARAM_DVFS_FLAG */
+	u16 ddr_type;			/* DRAMC_PARAM_DDR_TYPE */
+	u16 ddr_geometry;		/* DRAMC_PARAM_GEOMETRY_TYPE */
+	u16 voltage_type;		/* DRAM_PARAM_VOLTAGE_TYPE */
+	u32 support_ranks;
+	u64 rank_size[RANK_MAX];
+	struct emi_mdl emi_config;
+	dram_cbt_mode cbt_mode[RANK_MAX];
+};
+
+struct dramc_data {
+	struct ddr_base_info ddr_info;
+	struct sdram_params freq_params[DRAM_DFS_SHU_MAX];
+};
+
+struct dramc_param {
+	struct dramc_param_header header;
+	void (*do_putc)(unsigned char c);
+	struct dramc_data dramc_datas;
+};
+
+struct dramc_param_ops {
+	struct dramc_param *param;
+	bool (*read_from_flash)(struct dramc_param *dparam);
+	bool (*write_to_flash)(const struct dramc_param *dparam);
+};
+
+struct sdram_info {
+	u32 ddr_geometry;		/* DRAMC_PARAM_GEOMETRY_TYPE */
+};
+
+const struct sdram_info *get_sdram_config(void);
+struct dramc_param *get_dramc_param_from_blob(void *blob);
+void dump_param_header(const void *blob);
+int validate_dramc_param(const void *blob);
+int is_valid_dramc_param(const void *blob);
+int initialize_dramc_param(void *blob);
+#endif  /* __SOC_MEDIATEK_MT8192_DRAMC_PARAM_H__ */
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/44566
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3bae57e6777ab6fc46c771a034f814dd1175be95
Gerrit-Change-Number: 44566
Gerrit-PatchSet: 1
Gerrit-Owner: CK HU ck.hu@mediatek.com
Gerrit-Reviewer: Duan huayang huayang.duan@mediatek.com
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-MessageType: newchange



    