Attention is currently required from: Martin L Roth.
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68926 )
Change subject: commonlib...cbmem_id.h: Add AMD STB buffer IDs for CBMEM
......................................................................
Patch Set 1:
(1 comment)
File src/commonlib/bsd/include/commonlib/bsd/cbmem_id.h:
https://review.coreboot.org/c/coreboot/+/68926/comment/5a739faa_0a2354b2
PS1, Line 164: { CBMEM_ID_AMD_STB, "AMD MP2 BUFFER"}
nit: Should this have a blank line before the #endif? […]
We still need to add a backslash at the end when adding another entry.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68926
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I27157ad65df992bcdd0e0d15a6d01b96e24067c0
Gerrit-Change-Number: 68926
Gerrit-PatchSet: 1
Gerrit-Owner: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Comment-Date: Fri, 28 Oct 2022 21:44:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-MessageType: comment