[XS] Change in coreboot[main]: sconfig: Move config_of_soc from device.h to static.h - coreboot-gerrit

21 Sep 2024


      Attention is currently required from: Julius Werner, Martin L Roth, Nicholas Chin.
Nico Huber has posted comments on this change by Nicholas Chin. ( https://review.coreboot.org/c/coreboot/+/84431?usp=email )
Change subject: sconfig: Move config_of_soc from device.h to static.h
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
File src/include/device/devicetree.h:
PS1:
...
Acknowledged. I simply moved config_of_soc directly into static. […]
It's only referencing an external void pointer. So there's another alternative:
Just put `extern DEVTREE_CONST void *const __pci_0_00_0_config;` in front of
the function in `device.h`. I don't have a preference.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/84431?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I7c40135bf2815093b81e47201c38b7d0a6ac8fa8
Gerrit-Change-Number: 84431
Gerrit-PatchSet: 2
Gerrit-Owner: Nicholas Chin nic.c3.14@gmail.com
Gerrit-Reviewer: Martin L Roth gaumless@gmail.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Julius Werner jwerner@chromium.org
Gerrit-Attention: Martin L Roth gaumless@gmail.com
Gerrit-Attention: Julius Werner jwerner@chromium.org
Gerrit-Attention: Nicholas Chin nic.c3.14@gmail.com
Gerrit-Comment-Date: Sat, 21 Sep 2024 14:53:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Julius Werner jwerner@chromium.org
Comment-In-Reply-To: Nicholas Chin nic.c3.14@gmail.com