Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/50848 )
Change subject: util/cbfstool: Update Makefiles ......................................................................
util/cbfstool: Update Makefiles
- Add a distclean target - Add a help target - Add the -Wshadow option
Signed-off-by: Martin Roth martin@coreboot.org Change-Id: Ie31d61bd0e28b1e228656dfa09b5ab1996868706 Reviewed-on: https://review.coreboot.org/c/coreboot/+/50848 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Patrick Georgi pgeorgi@google.com Reviewed-by: Angel Pons th3fanbus@gmail.com --- M util/cbfstool/Makefile M util/cbfstool/Makefile.inc 2 files changed, 14 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved Angel Pons: Looks good to me, but someone else must approve
diff --git a/util/cbfstool/Makefile b/util/cbfstool/Makefile index ad8f9a8..7ef46a7 100644 --- a/util/cbfstool/Makefile +++ b/util/cbfstool/Makefile @@ -48,7 +48,7 @@ mv trampoline.c linux_trampoline.c rm linux_trampoline trampoline
-.PHONY: install +.PHONY: install distclean help install: all mkdir -p $(DESTDIR)$(BINDIR) $(INSTALL) cbfstool $(DESTDIR)$(BINDIR) @@ -58,6 +58,18 @@ $(INSTALL) ifittool $(DESTDIR)$(BINDIR) $(INSTALL) cbfs-compression-tool $(DESTDIR)$(BINDIR)
+distclean: clean + +help: + @echo "cbfstool & associated tools" + @echo "Targets: all, clean, distclean, help" + @echo " cbfstool - Manipulate CBFS images" + @echo " fmaptool - Compile Flashmap descriptor (fmd) files" + @echo " rmodtool - Create relocatable modules" + @echo " ifwitool - Manipulate Intel FW Image (IFWI)" + @echo " ifittool - Manipulate Intel FW Interface Table (FIT)" + @echo " cbfs-compression-tool - benchmark compression algorithms" + ifneq ($(V),1) .SILENT: endif diff --git a/util/cbfstool/Makefile.inc b/util/cbfstool/Makefile.inc index 536aef5..4ef224c 100644 --- a/util/cbfstool/Makefile.inc +++ b/util/cbfstool/Makefile.inc @@ -87,7 +87,7 @@ amdcompobj += common.o amdcompobj += xdr.o
-TOOLCFLAGS ?= -Werror -Wall -Wextra +TOOLCFLAGS ?= -Werror -Wall -Wextra -Wshadow TOOLCFLAGS += -Wcast-qual -Wmissing-prototypes -Wredundant-decls -Wshadow TOOLCFLAGS += -Wstrict-prototypes -Wwrite-strings TOOLCFLAGS += -O2
-
Patrick Georgi (Code Review)