Attention is currently required from: Nico Huber, Martin Roth, Angel Pons, Meera Ravindranath, Michael Niewöhner. Hello build bot (Jenkins), Nico Huber, Patrick Georgi, Martin Roth, Paul Menzel, Tim Wawrzynczak, Angel Pons, Meera Ravindranath, Subrata Banik,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/49433
to look at the new patch set (#13).
Change subject: mb/intel/adlrvp: do UART pad config at board-level ......................................................................
mb/intel/adlrvp: do UART pad config at board-level
UART pad configuration should not be done in common code, because that may cause short circuits, when the user sets a wrong UART index. Thus, add the corresponding pads to the early UART gpio table for the board as a first step. Common UART pad config code then gets dropped in CB:48829.
Also switch to `bootblock_mainboard_early_init` to configure the pads in early bootblock before console initialization, to make the console work as early as possible. The board does not do any other gpio configuration in bootblock, so this should not influence behaviour in a negative way (e.g. breaking overrides).
Change-Id: I55815a824ea3a77e6e603ba4beb17457f37c48f5 Signed-off-by: Michael Niewöhner foss@mniewoehner.de --- M src/include/device/pci_type.h M src/mainboard/intel/adlrvp/bootblock.c M src/mainboard/intel/adlrvp/early_gpio.c M src/soc/intel/alderlake/uart.c M src/soc/intel/apollolake/uart.c M src/soc/intel/cannonlake/bootblock/bootblock.c M src/soc/intel/cannonlake/uart.c M src/soc/intel/common/block/include/intelblocks/uart.h M src/soc/intel/common/block/uart/Kconfig M src/soc/intel/common/block/uart/uart.c M src/soc/intel/elkhartlake/uart.c M src/soc/intel/icelake/uart.c M src/soc/intel/jasperlake/uart.c M src/soc/intel/skylake/uart.c M src/soc/intel/tigerlake/uart.c 15 files changed, 72 insertions(+), 333 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/49433/13