Attention is currently required from: Christian Walter, Arthur Heymans. Hello Arthur Heymans,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/63070
to review the following change.
Change subject: security/tpm/crtm.c: Remove set but unused variable ......................................................................
security/tpm/crtm.c: Remove set but unused variable
Change-Id: I3c97cb57fe13adee217783973691748d6c542abe Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/security/tpm/tspi/crtm.c 1 file changed, 0 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/70/63070/1
diff --git a/src/security/tpm/tspi/crtm.c b/src/security/tpm/tspi/crtm.c index 8cd0793..2d0901d 100644 --- a/src/security/tpm/tspi/crtm.c +++ b/src/security/tpm/tspi/crtm.c @@ -140,7 +140,6 @@ int tspi_measure_cache_to_pcr(void) { int i; - enum vb2_hash_algorithm hash_alg; struct tcpa_table *tclt = tcpa_log_init();
/* This means the table is empty. */ @@ -151,11 +150,6 @@ printk(BIOS_WARNING, "TCPA: Log non-existent!\n"); return VB2_ERROR_UNKNOWN; } - if (CONFIG(TPM1)) { - hash_alg = VB2_HASH_SHA1; - } else { /* CONFIG_TPM2 */ - hash_alg = VB2_HASH_SHA256; - }
printk(BIOS_DEBUG, "TPM: Write digests cached in TCPA log to PCR\n"); for (i = 0; i < tclt->num_entries; i++) {