Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/62502 )
Change subject: acpi/acpi: drop weak cpu_get_lapic_addr implementation ......................................................................
acpi/acpi: drop weak cpu_get_lapic_addr implementation
All SoCs/chipsets that select ARCH_X86 will end up using the implementation in cpu/x86/lapic/lapic.c, so to avoid confusion, drop the unused weak implementation that returns a different value.
Signed-off-by: Felix Held felix-coreboot@felixheld.de Change-Id: Iffcd8c80260f9a7d81dda41a0ad08bffc7620c33 Reviewed-on: https://review.coreboot.org/c/coreboot/+/62502 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Raul Rangel rrangel@chromium.org --- M src/acpi/acpi.c 1 file changed, 0 insertions(+), 9 deletions(-)
Approvals: build bot (Jenkins): Verified Raul Rangel: Looks good to me, approved
diff --git a/src/acpi/acpi.c b/src/acpi/acpi.c index 4e2b8df..f7545b2 100644 --- a/src/acpi/acpi.c +++ b/src/acpi/acpi.c @@ -224,15 +224,6 @@ return lapic_nmi->length; }
-__weak uintptr_t cpu_get_lapic_addr(void) -{ - /* - * If an architecture does not support LAPIC, this weak implementation returns LAPIC - * addr as 0. - */ - return 0; -} - void acpi_create_madt(acpi_madt_t *madt) { acpi_header_t *header = &(madt->header);