Attention is currently required from: Sam McNally, Reka Norman, Rizwan Qureshi, Tim Wawrzynczak, Angel Pons.
Reka Norman has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63365 )
Change subject: soc/intel/alderlake: Add support to update descriptor at runtime
......................................................................
Patch Set 4:
(1 comment)
File src/soc/intel/alderlake/include/soc/bootblock.h:
https://review.coreboot.org/c/coreboot/+/63365/comment/df2441c4_1bb9a949
PS4, Line 20: void configure_pmc_descriptor(void);
Shouldn't this have been removed with the previous commit?
Yeah, Sridhar would you mind doing this? Then I'll update my change.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63365
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I43c4d2888706561e42ff6b8ce0377eedbc38dbfe
Gerrit-Change-Number: 63365
Gerrit-PatchSet: 4
Gerrit-Owner: Reka Norman
rekanorman@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Reka Norman
rekanorman@google.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Sam McNally
sammc@google.com
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Sam McNally
sammc@google.com
Gerrit-Attention: Reka Norman
rekanorman@google.com
Gerrit-Attention: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Tue, 05 Apr 2022 08:54:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment