Attention is currently required from: Tim Wawrzynczak, Zhuohao Lee, Patrick Rudolph.
Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60274 )
Change subject: soc/intel/common/block/gpio: add variant_gpio_lock_config()
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
Given those options, I would opt for modifying mb_gpio_lock_config() api to allow for passing back t […]
I decided to add a bool *delete parameter to mb_gpio_lock_config() that will indicate to the caller whether or not to delete the memory returned after using the list. This should address all concerns.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/60274
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3edc309335b2751a85b479250ee0c470ea842c2e
Gerrit-Change-Number: 60274
Gerrit-PatchSet: 2
Gerrit-Owner: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Zhuohao Lee
zhuohao@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Zhuohao Lee
zhuohao@google.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Wed, 22 Dec 2021 19:43:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: Nick Vaccaro
nvaccaro@google.com
Gerrit-MessageType: comment