Change in coreboot[master]: soc/intel/cnl: replace the remaints of HeciEnabled by device state in dt
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47195 )
Change subject: soc/intel/cnl: replace the remaints of HeciEnabled by device state in dt ......................................................................
Patch Set 9:
(2 comments)
https://review.coreboot.org/c/coreboot/+/47195/8//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/47195/8//COMMIT_MSG@11 PS8, Line 11: gets : always gets
only one `gets` is enough
Done
https://review.coreboot.org/c/coreboot/+/47195/8/src/soc/intel/cannonlake/sm... File src/soc/intel/cannonlake/smihandler.c:
https://review.coreboot.org/c/coreboot/+/47195/8/src/soc/intel/cannonlake/sm... PS8, Line 23: CONFIG(HECI_DISABLE_USING_SMM)
I'd rather place this check before the pcidev_path_on_root() call: […]
Ack
-
Michael Niewöhner (Code Review)