Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/61642 )
Change subject: drivers/uart/uart8250reg.h: remove duplicate bit definitions ......................................................................
drivers/uart/uart8250reg.h: remove duplicate bit definitions
UART8250_FCR_RXSR is a redefinition of UART8250_FCR_CLEAR_RCVR, UART8250_FCR_TXSR a redefinition of UART8250_FCR_CLEAR_XMIT and UART8250_LCR_BKSE a redefinition of UART8250_LCR_DLAB. None of those redefinitions are used, so just drop them.
Signed-off-by: Felix Held felix-coreboot@felixheld.de Change-Id: I6b9edae67180b04ff1c887c5742c07c774fc9c59 Reviewed-on: https://review.coreboot.org/c/coreboot/+/61642 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: HAOUAS Elyes ehaouas@noos.fr --- M src/drivers/uart/uart8250reg.h 1 file changed, 0 insertions(+), 4 deletions(-)
Approvals: build bot (Jenkins): Verified HAOUAS Elyes: Looks good to me, approved
diff --git a/src/drivers/uart/uart8250reg.h b/src/drivers/uart/uart8250reg.h index 28dc21c..573eb6f 100644 --- a/src/drivers/uart/uart8250reg.h +++ b/src/drivers/uart/uart8250reg.h @@ -34,9 +34,6 @@ #define UART8250_FCR_TRIGGER_8 0x80 /* Mask for trigger set at 8 */ #define UART8250_FCR_TRIGGER_14 0xC0 /* Mask for trigger set at 14 */
-#define UART8250_FCR_RXSR 0x02 /* Receiver soft reset */ -#define UART8250_FCR_TXSR 0x04 /* Transmitter soft reset */ - #define UART8250_LCR 0x03 #define UART8250_LCR_WLS_MSK 0x03 /* character length select mask */ #define UART8250_LCR_WLS_5 0x00 /* 5 bit character length */ @@ -48,7 +45,6 @@ #define UART8250_LCR_EPS 0x10 /* Even Parity Select */ #define UART8250_LCR_STKP 0x20 /* Stick Parity */ #define UART8250_LCR_SBRK 0x40 /* Set Break */ -#define UART8250_LCR_BKSE 0x80 /* Bank select enable */ #define UART8250_LCR_DLAB 0x80 /* Divisor latch access bit */
#define UART8250_MCR 0x04