Attention is currently required from: Bora Guvendik, Anil Kumar K, Selma Bensaid, Tim Wawrzynczak, Paul Menzel, Thejaswani Putta. Cliff Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61354 )
Change subject: drivers/wwan/fm: Add Fibocom 5G WWAN ACPI support ......................................................................
Patch Set 2:
(15 comments)
File src/drivers/wwan/fm/acpi_fm350gl.c:
https://review.coreboot.org/c/coreboot/+/61354/comment/96f136f1_a4cfc8cb PS2, Line 25: initializatioin
`initialization`
Done
https://review.coreboot.org/c/coreboot/+/61354/comment/62c0ee9e_1038d91d PS2, Line 26: rtd3
`RTD3`
Done
https://review.coreboot.org/c/coreboot/+/61354/comment/47e4aa97_41f21aa0 PS2, Line 57: acpigen_pop_len
`acpigen_write_if_end()`
Done. I didn't know about these are available. nice.
https://review.coreboot.org/c/coreboot/+/61354/comment/eb19b318_feaf2723 PS2, Line 59: acpigen_pop_len
`acpigen_write_method_end()`
Done
https://review.coreboot.org/c/coreboot/+/61354/comment/ba671384_63c01e60 PS2, Line 82: acpigen_pop_len
`acpigen_write_method_end()`
Done
https://review.coreboot.org/c/coreboot/+/61354/comment/2cee2ef9_ef89cc86 PS2, Line 98: acpigen_pop_len
`acpigen_write_method_end`
Done
https://review.coreboot.org/c/coreboot/+/61354/comment/d624a40c_7d213696 PS2, Line 114: acpigen_pop_len
`acpigen_write_method_end`
Done
https://review.coreboot.org/c/coreboot/+/61354/comment/ddd89928_9daabe88 PS2, Line 155: the 5G driver is looking for MRST._RST for cold reset called during : * firmware update.
suggestion: […]
Done
https://review.coreboot.org/c/coreboot/+/61354/comment/d3921094_207a53c0 PS2, Line 161: acpigen_pop_len
We added a few new niceities for this like […]
Done
https://review.coreboot.org/c/coreboot/+/61354/comment/8f29e6d4_a7405d4c PS2, Line 162: acpigen_pop_len
`acpigen_write_device_end()`
Done
https://review.coreboot.org/c/coreboot/+/61354/comment/b04ac5fa_06c0d297 PS2, Line 163: acpigen_pop_len
`acpigen_write_scope_end()`
Done
File src/drivers/wwan/fm/chip.h:
https://review.coreboot.org/c/coreboot/+/61354/comment/13b550b1_da2b5e28 PS2, Line 10: fcpo
nit: […]
Done
https://review.coreboot.org/c/coreboot/+/61354/comment/ec647b1a_c7d238c1 PS2, Line 17: reset
nit: […]
Done
https://review.coreboot.org/c/coreboot/+/61354/comment/03313fc0_6268e88f PS2, Line 24: perst
nit: […]
Done
https://review.coreboot.org/c/coreboot/+/61354/comment/a6648ddf_943d4286 PS2, Line 30: wake
nit: […]
Done
-
Cliff Huang (Code Review)