Attention is currently required from: Tim Wawrzynczak, Andrey Petrov, Patrick Rudolph.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58986 )
Change subject: drivers/intel/fsp2_0: Add FSP_ALIGNMENT_FSP_X option
......................................................................
Patch Set 3:
(2 comments)
File src/drivers/intel/fsp2_0/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/58986/comment/272275d7_6602cfa5
PS2, Line 69: alignment
Unless I missed a change in this train, shouldn't this be […]
lol you are right. I guess I got lucky when I removed the `-b` since the file ended up 64 byte aligned when I tested.
https://review.coreboot.org/c/coreboot/+/58986/comment/414ed6d0_b0561484
PS2, Line 82: alignment
same?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58986
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4533f6c9d56bea6520aa3aa87dd49f2144a23850
Gerrit-Change-Number: 58986
Gerrit-PatchSet: 3
Gerrit-Owner: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Fri, 05 Nov 2021 22:47:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment