Change in coreboot[master]: mb/advansus: Use 'Device()' instead of 'Processor()'

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36303 )

Change subject: mb/advansus: Use 'Device()' instead of 'Processor()'
......................................................................

mb/advansus: Use 'Device()' instead of 'Processor()'

Processor() Keyword is deprecated, use Device() instead.

Change-Id: I805291716ab3395736d8a70a18468f247d9f4edf
Signed-off-by: Elyes HAOUAS 
---
M src/mainboard/advansus/a785e-i/acpi/cpstate.asl
M src/mainboard/advansus/a785e-i/dsdt.asl
2 files changed, 24 insertions(+), 31 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/36303/1

diff --git a/src/mainboard/advansus/a785e-i/acpi/cpstate.asl b/src/mainboard/advansus/a785e-i/acpi/cpstate.asl
index 5d71c81..18f5b47 100644
--- a/src/mainboard/advansus/a785e-i/acpi/cpstate.asl
+++ b/src/mainboard/advansus/a785e-i/acpi/cpstate.asl
@@ -23,16 +23,24 @@
 DefinitionBlock ("DSDT.AML", "DSDT", 0x01, OEM_ID, ACPI_TABLE_CREATOR, 0x00010001)
    {
    	Scope (_PR) {
-		Processor(CPU0,0,0x808,0x06) {
+		Device (CPU0) {
+		Name (_HID, "ACPI0007")
+		Name (_UID, 0)
    		#include "cpstate.asl"
    	}
-		Processor(CPU1,1,0x0,0x0) {
+		Device (CPU1) {
+		Name (_HID, "ACPI0007")
+		Name (_UID, 1)
    		#include "cpstate.asl"
    	}
-		Processor(CPU2,2,0x0,0x0) {
+		Device (CPU2) {
+		Name (_HID, "ACPI0007")
+		Name (_UID, 2)
    		#include "cpstate.asl"
    	}
-		Processor(CPU3,3,0x0,0x0) {
+		Device (CPU3) {
+		Name (_HID, "ACPI0007")
+		Name (_UID, 3)
    		#include "cpstate.asl"
    	}
    }
diff --git a/src/mainboard/advansus/a785e-i/dsdt.asl b/src/mainboard/advansus/a785e-i/dsdt.asl
index 4eececb..8015ec6 100644
--- a/src/mainboard/advansus/a785e-i/dsdt.asl
+++ b/src/mainboard/advansus/a785e-i/dsdt.asl
@@ -58,39 +58,24 @@
     *
     */
    Scope (_PR) {		/* define processor scope */
-		Processor(
-			CPU0,		/* name space name */
-			0,		/* Unique number for this processor */
-			0x808,		/* PBLK system I/O address !hardcoded! */
-			0x06		/* PBLKLEN for boot processor */
-			) {
+		Device (CPU0) {
+		Name (_HID, "ACPI0007")
+		Name (_UID, 0)
    		#include "acpi/cpstate.asl"
    	}
-
-		Processor(
-			CPU1,		/* name space name */
-			1,		/* Unique number for this processor */
-			0x0000,		/* PBLK system I/O address !hardcoded! */
-			0x00		/* PBLKLEN for boot processor */
-			) {
+		Device (CPU1) {
+		Name (_HID, "ACPI0007")
+		Name (_UID, 1)
    		#include "acpi/cpstate.asl"
    	}
-
-		Processor(
-			CPU2,		/* name space name */
-			2,		/* Unique number for this processor */
-			0x0000,		/* PBLK system I/O address !hardcoded! */
-			0x00		/* PBLKLEN for boot processor */
-			) {
+		Device (CPU2) {
+		Name (_HID, "ACPI0007")
+		Name (_UID, 2)
    		#include "acpi/cpstate.asl"
    	}
-
-		Processor(
-			CPU3,		/* name space name */
-			3,		/* Unique number for this processor */
-			0x0000,		/* PBLK system I/O address !hardcoded! */
-			0x00		/* PBLKLEN for boot processor */
-			) {
+		Device (CPU3) {
+		Name (_HID, "ACPI0007")
+		Name (_UID, 3)
    		#include "acpi/cpstate.asl"
    	}
    } /* End _PR scope */

[HAOUAS Elyes (Code Review)]

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/36303

to look at the new patch set (#2).

Change subject: mb/advansus: Use 'Device()' instead of 'Processor()'
......................................................................

mb/advansus: Use 'Device()' instead of 'Processor()'

Processor() Keyword is deprecated, use Device() instead.

Change-Id: I805291716ab3395736d8a70a18468f247d9f4edf
Signed-off-by: Elyes HAOUAS 
---
M src/mainboard/advansus/a785e-i/acpi/cpstate.asl
M src/mainboard/advansus/a785e-i/dsdt.asl
2 files changed, 25 insertions(+), 32 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/36303/2

[Martin Roth (Code Review)]

Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36303 )

Change subject: mb/advansus: Use 'Device()' instead of 'Processor()'
......................................................................

Patch Set 2: Code-Review+2

[Martin Roth (Code Review)]

Martin Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/36303 )

Change subject: mb/advansus: Use 'Device()' instead of 'Processor()'
......................................................................

mb/advansus: Use 'Device()' instead of 'Processor()'

Processor() Keyword is deprecated, use Device() instead.

Change-Id: I805291716ab3395736d8a70a18468f247d9f4edf
Signed-off-by: Elyes HAOUAS 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/36303
Tested-by: build bot (Jenkins) 
Reviewed-by: Martin Roth 
---
M src/mainboard/advansus/a785e-i/acpi/cpstate.asl
M src/mainboard/advansus/a785e-i/dsdt.asl
2 files changed, 25 insertions(+), 32 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Martin Roth: Looks good to me, approved

diff --git a/src/mainboard/advansus/a785e-i/acpi/cpstate.asl b/src/mainboard/advansus/a785e-i/acpi/cpstate.asl
index 5d71c81..eb4eac1 100644
--- a/src/mainboard/advansus/a785e-i/acpi/cpstate.asl
+++ b/src/mainboard/advansus/a785e-i/acpi/cpstate.asl
@@ -22,17 +22,25 @@
 #include <arch/acpi.h>
 DefinitionBlock ("DSDT.AML", "DSDT", 0x01, OEM_ID, ACPI_TABLE_CREATOR, 0x00010001)
    {
-		Scope (_PR) {
-		Processor(CPU0,0,0x808,0x06) {
+	Scope (_PR) {
+		Device (CPU0) {
+		Name (_HID, "ACPI0007")
+		Name (_UID, 0)
    		#include "cpstate.asl"
    	}
-		Processor(CPU1,1,0x0,0x0) {
+		Device (CPU1) {
+		Name (_HID, "ACPI0007")
+		Name (_UID, 1)
    		#include "cpstate.asl"
    	}
-		Processor(CPU2,2,0x0,0x0) {
+		Device (CPU2) {
+		Name (_HID, "ACPI0007")
+		Name (_UID, 2)
    		#include "cpstate.asl"
    	}
-		Processor(CPU3,3,0x0,0x0) {
+		Device (CPU3) {
+		Name (_HID, "ACPI0007")
+		Name (_UID, 3)
    		#include "cpstate.asl"
    	}
    }
diff --git a/src/mainboard/advansus/a785e-i/dsdt.asl b/src/mainboard/advansus/a785e-i/dsdt.asl
index 4eececb..8015ec6 100644
--- a/src/mainboard/advansus/a785e-i/dsdt.asl
+++ b/src/mainboard/advansus/a785e-i/dsdt.asl
@@ -58,39 +58,24 @@
     *
     */
    Scope (_PR) {		/* define processor scope */
-		Processor(
-			CPU0,		/* name space name */
-			0,		/* Unique number for this processor */
-			0x808,		/* PBLK system I/O address !hardcoded! */
-			0x06		/* PBLKLEN for boot processor */
-			) {
+		Device (CPU0) {
+		Name (_HID, "ACPI0007")
+		Name (_UID, 0)
    		#include "acpi/cpstate.asl"
    	}
-
-		Processor(
-			CPU1,		/* name space name */
-			1,		/* Unique number for this processor */
-			0x0000,		/* PBLK system I/O address !hardcoded! */
-			0x00		/* PBLKLEN for boot processor */
-			) {
+		Device (CPU1) {
+		Name (_HID, "ACPI0007")
+		Name (_UID, 1)
    		#include "acpi/cpstate.asl"
    	}
-
-		Processor(
-			CPU2,		/* name space name */
-			2,		/* Unique number for this processor */
-			0x0000,		/* PBLK system I/O address !hardcoded! */
-			0x00		/* PBLKLEN for boot processor */
-			) {
+		Device (CPU2) {
+		Name (_HID, "ACPI0007")
+		Name (_UID, 2)
    		#include "acpi/cpstate.asl"
    	}
-
-		Processor(
-			CPU3,		/* name space name */
-			3,		/* Unique number for this processor */
-			0x0000,		/* PBLK system I/O address !hardcoded! */
-			0x00		/* PBLKLEN for boot processor */
-			) {
+		Device (CPU3) {
+		Name (_HID, "ACPI0007")
+		Name (_UID, 3)
    		#include "acpi/cpstate.asl"
    	}
    } /* End _PR scope */