Attention is currently required from: Hung-Te Lin, Jarried Lin, Yu-Ping Wu.
Yidi Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/84025?usp=email )
Change subject: soc/mediatek/mt8196: add unmask eint event for bootblock ......................................................................
Patch Set 7:
(7 comments)
File src/soc/mediatek/mt8196/bootblock.c:
https://review.coreboot.org/c/coreboot/+/84025/comment/c9a03466_79697259?usp... : PS7, Line 6: #include <soc/eint_event.h> sort
File src/soc/mediatek/mt8196/eint_event.c:
https://review.coreboot.org/c/coreboot/+/84025/comment/8b89ba36_4027a0fe?usp... : PS7, Line 2: #include <soc/addressmap.h> : #include <console/console.h> : #include <soc/eint_event.h> sort
https://review.coreboot.org/c/coreboot/+/84025/comment/9e0440e8_9b3c49f3?usp... : PS7, Line 6: void static void
https://review.coreboot.org/c/coreboot/+/84025/comment/39735858_b06ecfe1?usp... : PS7, Line 11: *(unsigned int *)(base + EVENT_MASK_CLEAN + i * NEXT_ADDRESS) = MASK_VALUE; write32p
https://review.coreboot.org/c/coreboot/+/84025/comment/c691508a_16435398?usp... : PS7, Line 13: dsb(); no need.
File src/soc/mediatek/mt8196/include/soc/eint_event.h:
PS7: just use `soc/eint_event.h` in the common folder
https://review.coreboot.org/c/coreboot/+/84025/comment/4acf9cf4_ec88674d?usp... : PS7, Line 7: #define EVENT_MASK_CLEAN 0x880 : #define NEXT_ADDRESS 4 : #define MASK_VALUE 0xFFFFFFFF : #define MAX_E 3 : #define MAX_S 2 : #define MAX_W 2 : #define MAX_N 2 : #define MAX_C 1 move to `eint_event.c`