Attention is currently required from: Nico Huber, Subrata Banik, Patrick Rudolph. Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61380 )
Change subject: soc/inte/common: Add support to control coreboot and Intel SoC features ......................................................................
Patch Set 2:
(1 comment)
File src/soc/intel/common/block/debug/debug_feature.c:
https://review.coreboot.org/c/coreboot/+/61380/comment/a834fca5_0c503d5a PS2, Line 28: cse_fw_update_disable
why not `cse_fw_update_enable` ?
Assumption is, coreboot enables a feature by default and debug logic look for OEM SECTION if the feature is disabled or not. Hence, so identifier is chosen to reflect it's purpose. When OEM section indicates a feature has to be disabled, then override logic reverts the feature.
In this case, coreboot native logic enables cse fw update, but debug logic will disable the CSE FW update if user disables the feature in the OEM SECTION.