[M] Change in coreboot[main]: drivers/51nb/thunderbolt/thunderbolt.c: Init Alpine Ridge card

[Angel Pons (Code Review)]

Attention is currently required from: Rafael Send.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49672?usp=email )

Change subject: drivers/51nb/thunderbolt/thunderbolt.c: Init Alpine Ridge card
......................................................................

Patch Set 8:

(3 comments)

File src/drivers/51nb/thunderbolt/chip.h:

https://review.coreboot.org/c/coreboot/+/49672/comment/728a606b_294b2489 :
PS7, Line 3: #ifndef DRIVERS_51NB_THUNDERBOLT
           : #define DRIVERS_51NB_THUNDERBOLT
           : #endif /* DRIVERS_51NB_THUNDERBOLT */
           : 
           : struct drivers_51nb_thunderbolt_config {};
> Put the struct definition between the #ifndef and the #endif: […]

Done

File src/drivers/51nb/thunderbolt/chip.h:

https://review.coreboot.org/c/coreboot/+/49672/comment/2b7b3464_a25dbea9 :
PS1, Line 4: #define DRIVERS_51NB_THUNDERBOLT
> You should define a `struct drivers_51nb_thunderbolt_config` type here.

Done

File src/drivers/51nb/thunderbolt/thunderbolt.c:

https://review.coreboot.org/c/coreboot/+/49672/comment/57082d36_695c2300 :
PS7, Line 14: u16 count = 0;
            : mdelay(100);
            : u16 is_tb = pci_read_config16(dev, 0x504);
            : printk(BIOS_INFO, "-----------------REACHED THUNDERBOLT ENABLE ---------------\n");
            : printk(BIOS_INFO, "Thunderbolt device check register value:%x\n", is_tb);
            : if ((pci_read_config16(dev, 0x548) & 0x1) != 1) {
            : 	pci_write_config16(dev, 0x54C, 0xd);
            : 	while ((pci_read_config16(dev, 0x548) & 0x1) != 1 && count < 5000) {
            : 		mdelay(1);
            : 		count++;
            : 	}
            : 	if (count == 5000) {
            : 		printk(BIOS_INFO, "Loop timed out waiting for bit change\n");
            : 	}
            : 	pci_write_config16(dev, 0x54C, 0);
            : }
            : mdelay(600);
            : //printk(BIOS_INFO, " Thunderbolt set register value to: %x\n", is_written);
            : printk(BIOS_INFO, "Device ID: %x\n", pci_read_config16(dev, PCI_DEVICE_ID));
            : printk(BIOS_INFO, "Vendor ID: %x\n", pci_read_config16(dev, PCI_VENDOR_ID));
> This whole section needs an extra tab

Done