Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31677 )
Change subject: device/pci_ops: Avoid name collisions ......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/#/c/31677/1/src/arch/x86/include/arch/pci_io_cfg... File src/arch/x86/include/arch/pci_io_cfg.h:
https://review.coreboot.org/#/c/31677/1/src/arch/x86/include/arch/pci_io_cfg... PS1, Line 81: Add a comment describing what 's' means?
https://review.coreboot.org/#/c/31677/1/src/include/device/pci_mmio_cfg.h File src/include/device/pci_mmio_cfg.h:
https://review.coreboot.org/#/c/31677/1/src/include/device/pci_mmio_cfg.h@a7... PS1, Line 75: ditto about comment
https://review.coreboot.org/#/c/31677/1/src/include/device/pci_ops.h File src/include/device/pci_ops.h:
https://review.coreboot.org/#/c/31677/1/src/include/device/pci_ops.h@9 PS1, Line 9: #define pci_read_config8 pci_s_read_config8 and here too