Attention is currently required from: Felix Held, Fred Reitberger, Jason Glenesk, Karthik Ramasubramanian, Matt DeVillier, Stefan Reinauer, ron minnich.
Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80714?usp=email )
Change subject: util/amdfwtool: build amdfwtool only for all tools or AMD CPUs
......................................................................
Patch Set 2:
(3 comments)
File Makefile:
https://review.coreboot.org/c/coreboot/+/80714/comment/807a8a26_5dd84582 :
PS2, Line 143:
: ifneq ($(filter tools, $(MAKECMDGOALS)), )
: BUILD_ALL_TOOLS:=1
: endif
What does this do? A comment about the intention would be nice
Done
File util/amdfwtool/Makefile:
https://review.coreboot.org/c/coreboot/+/80714/comment/27907e80_4400a472 :
PS2, Line 20: BUILD_ALL_TOOLS := 1
Do we need this? IIUC the build targets in this makefile here will apply when a user comes into this […]
Not the way it's written now. I've removed this from this patch and added it to a follow-on that rewrites the Makefile to use what we can from Makefile.mk so that we don't need to update two makefiles when something changes.
File util/amdfwtool/Makefile.mk:
https://review.coreboot.org/c/coreboot/+/80714/comment/d55816d9_cd626d5d :
PS2, Line 31: endif #($(CONFIG_USE_AMDFWTOOL),y)
#($(BUILD_ALL_TOOLS)$(CONFIG_USE_AMDFWTOOL),)
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80714?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I9021674a06d65a79e24020790d317ab947c505fe
Gerrit-Change-Number: 80714
Gerrit-PatchSet: 2
Gerrit-Owner: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Attention: ron minnich
rminnich@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Fri, 23 Feb 2024 03:39:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Stefan Reinauer
stefan.reinauer@coreboot.org
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment