Change in coreboot[master]: arch/x86/include/bert_storage: introduce and use bert_generate_ssdt - coreboot-gerrit

28 May 2021


      Attention is currently required from: Arthur Heymans, Felix Held.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55024 )
Change subject: arch/x86/include/bert_storage: introduce and use bert_generate_ssdt
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
File src/arch/x86/include/arch/bert_storage.h:
https://review.coreboot.org/c/coreboot/+/55024/comment/eb9a06c9_1cf9c231 
PS2, Line 60: bert_generate_ssdt
To me, the `bert_generate_ssdt` function name sounds like it's a procedure that generates the BERT SSDT. Instead, I'd name this function `bert_should_generate_ssdt` to avoid confusion.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/55024
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia955f627c190ea38e05b5aaedc7cb2d030274e83
Gerrit-Change-Number: 55024
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Paul Menzel paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Arthur Heymans arthur@aheymans.xyz
Gerrit-Attention: Felix Held felix-coreboot@felixheld.de
Gerrit-Comment-Date: Fri, 28 May 2021 15:50:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment