Change in coreboot[master]: mb/google/zork/var/vilboz: Add Wifi SAR for Vilboz - coreboot-gerrit

11 Jan 2021


      Attention is currently required from: Frank Wu, Martin Roth, Furquan Shaikh, Kangheui Won, Rob Barnes.
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49296 )
Change subject: mb/google/zork/var/vilboz: Add Wifi SAR for Vilboz
......................................................................
Patch Set 5:
(1 comment)
File src/mainboard/google/zork/variants/baseboard/helpers.c:
https://review.coreboot.org/c/coreboot/+/49296/comment/fd48866a_d03c1277 
PS5, Line 89: 	return !!extract_field(FW_CONFIG_MASK_SAR, FW_CONFIG_SHIFT_SAR);
we don't want bool here. !! not needed.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/49296
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5ba98799e697010997b515ee88420d0ac14ca7ec
Gerrit-Change-Number: 49296
Gerrit-PatchSet: 5
Gerrit-Owner: Frank Wu frank_wu@compal.corp-partner.google.com
Gerrit-Reviewer: EricR Lai ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Kangheui Won khwon@chromium.org
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Rob Barnes robbarnes@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Alan Lee alan_lee@compal.corp-partner.google.com
Gerrit-Attention: Frank Wu frank_wu@compal.corp-partner.google.com
Gerrit-Attention: Martin Roth martinroth@google.com
Gerrit-Attention: Furquan Shaikh furquan@google.com
Gerrit-Attention: Kangheui Won khwon@chromium.org
Gerrit-Attention: Rob Barnes robbarnes@google.com
Gerrit-Comment-Date: Mon, 11 Jan 2021 12:06:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment