Change in coreboot[master]: mb/amd/mandolin: fix AUX/HDP mapping for last DDI port on Dali

[Felix Held (Code Review)]

Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44688 )

Change subject: mb/amd/mandolin: fix AUX/HDP mapping for last DDI port on Dali
......................................................................

mb/amd/mandolin: fix AUX/HDP mapping for last DDI port on Dali

We hit a similar issue on Cereme, so I checked the trembyle base board
which also uses AUX4/HDP4 for the last DDI port, so using AUX3/HDP3 is
wrong there.

Change-Id: I99f9426969488cc5c5a14bd432b38bfd69ae7ef0
Signed-off-by: Felix Held 
---
M src/mainboard/amd/mandolin/variants/mandolin/port_descriptors.c
1 file changed, 2 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/44688/1

diff --git a/src/mainboard/amd/mandolin/variants/mandolin/port_descriptors.c b/src/mainboard/amd/mandolin/variants/mandolin/port_descriptors.c
index 47e9aad..5213176 100644
--- a/src/mainboard/amd/mandolin/variants/mandolin/port_descriptors.c
+++ b/src/mainboard/amd/mandolin/variants/mandolin/port_descriptors.c
@@ -193,8 +193,8 @@
    },
    { /* DDI2 - DP */
    	.connector_type = DP,
-		.aux_index = AUX3,
-		.hdp_index = HDP3,
+		.aux_index = AUX4,
+		.hdp_index = HDP4,
    }
 };

[Raul Rangel (Code Review)]

Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44688 )

Change subject: mb/amd/mandolin: fix AUX/HDP mapping for last DDI port on Dali
......................................................................

Patch Set 1: Code-Review+2

[Matt Papageorge (Code Review)]

Matt Papageorge has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44688 )

Change subject: mb/amd/mandolin: fix AUX/HDP mapping for last DDI port on Dali
......................................................................

Patch Set 1: Code-Review+1

[Jason Glenesk (Code Review)]

Jason Glenesk has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44688 )

Change subject: mb/amd/mandolin: fix AUX/HDP mapping for last DDI port on Dali
......................................................................

Patch Set 1: Code-Review+1

[Felix Held (Code Review)]

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/44688 )

Change subject: mb/amd/mandolin: fix AUX/HDP mapping for last DDI port on Dali
......................................................................

mb/amd/mandolin: fix AUX/HDP mapping for last DDI port on Dali

We hit a similar issue on Cereme, so I checked the trembyle base board
which also uses AUX4/HDP4 for the last DDI port, so using AUX3/HDP3 is
wrong there.

Change-Id: I99f9426969488cc5c5a14bd432b38bfd69ae7ef0
Signed-off-by: Felix Held 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/44688
Tested-by: build bot (Jenkins) 
Reviewed-by: Raul Rangel 
Reviewed-by: Matt Papageorge 
Reviewed-by: Jason Glenesk 
---
M src/mainboard/amd/mandolin/variants/mandolin/port_descriptors.c
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Raul Rangel: Looks good to me, approved
  Matt Papageorge: Looks good to me, but someone else must approve
  Jason Glenesk: Looks good to me, but someone else must approve

diff --git a/src/mainboard/amd/mandolin/variants/mandolin/port_descriptors.c b/src/mainboard/amd/mandolin/variants/mandolin/port_descriptors.c
index 47e9aad..5213176 100644
--- a/src/mainboard/amd/mandolin/variants/mandolin/port_descriptors.c
+++ b/src/mainboard/amd/mandolin/variants/mandolin/port_descriptors.c
@@ -193,8 +193,8 @@
    },
    { /* DDI2 - DP */
    	.connector_type = DP,
-		.aux_index = AUX3,
-		.hdp_index = HDP3,
+		.aux_index = AUX4,
+		.hdp_index = HDP4,
    }
 };