Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34776 )
Change subject: cpu/x86/smm: Define single smm_subregion()
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34776/4/src/cpu/x86/smm/tseg_region...
File src/cpu/x86/smm/tseg_region.c:
https://review.coreboot.org/c/coreboot/+/34776/4/src/cpu/x86/smm/tseg_region...
PS4, Line 63: case SMM_SUBREGION_IED:
We can't put both here? […]
It's a matter of exposing implementation details into common x86 api. If that's not something anyone cares about then exposing IED there is fine.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34776
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9daf0dec8fbaaa1f4e6004ea034869f43412d7d5
Gerrit-Change-Number: 34776
Gerrit-PatchSet: 4
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: David Guckian
david.guckian@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Vanny E
vanessa.f.eusebio@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 08 Aug 2019 12:27:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-MessageType: comment