Change in coreboot[master]: mb/{adlrvp, brya, sm}: Set `pch_thermal_trip` for Dynamic Thermal Shu... - coreboot-gerrit

16 Nov 2021


      Attention is currently required from: Maulik V Vaghela, Subrata Banik.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59270 )
Change subject: mb/{adlrvp, brya, sm}: Set `pch_thermal_trip` for Dynamic Thermal Shutdown
......................................................................
Patch Set 4:
(1 comment)
File src/mainboard/google/brya/variants/baseboard/brask/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/59270/comment/65b046e2_8163f2ad 
PS4, Line 95: .pch_thermal_trip = 100,
Isn't there usually a recommended value per-chipset? Just wondering if `chipset.cb` for alderlake makes more sense here for setting the value to 100?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/59270
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7ee199c19a9d926a4135eeef3b3b481fbff74a79
Gerrit-Change-Number: 59270
Gerrit-PatchSet: 4
Gerrit-Owner: Subrata Banik subrata.banik@intel.com
Gerrit-Reviewer: EricR Lai ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Maulik V Vaghela maulik.v.vaghela@intel.com
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Maulik V Vaghela maulik.v.vaghela@intel.com
Gerrit-Attention: Subrata Banik subrata.banik@intel.com
Gerrit-Comment-Date: Tue, 16 Nov 2021 19:54:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment