Attention is currently required from: Andrey Petrov, Appukuttan V K, Paul Menzel, Ronak Kanabar.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81663?usp=email )
Change subject: drivers/intel/fsp2_0: Add dedicated caller function for ap procedure calls
......................................................................
Patch Set 5:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/81663/comment/f0d2e927_6576b0f1 :
PS5, Line 11: the appropriate C calling convention.
two things
1. please specify the BUG in this patch train w/o failing
2. Please specify test statement highlighting both 32-bit and 64-bit results.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81663?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I64e65b2941207375d5e27c84aa26061e7e72a7f6
Gerrit-Change-Number: 81663
Gerrit-PatchSet: 5
Gerrit-Owner: Appukuttan V K
appukuttan.vk@intel.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Appukuttan V K
appukuttan.vk@intel.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Attention: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Comment-Date: Fri, 19 Apr 2024 16:43:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment