9 Aug
2019
9 Aug
'19
6:05 p.m.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34784 )
Change subject: soc/mediatek: dsi: Refactor MIPI TX configuration ......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34784/7/src/soc/mediatek/mt8173/inc... File src/soc/mediatek/mt8173/include/soc/dsi.h:
https://review.coreboot.org/c/coreboot/+/34784/7/src/soc/mediatek/mt8173/inc... PS7, Line 24: #define MTK_DSI_DATA_RATE_MIN 50 nit: Can we put a unit here (e.g. MTK_DSI_DATA_RATE_MIN_MHZ or whatever it is)?
--
To view, visit https://review.coreboot.org/c/coreboot/+/34784
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I894dc2c4c053267debf5a58313b2bb489bcf5f3a
Gerrit-Change-Number: 34784
Gerrit-PatchSet: 7
Gerrit-Owner: Hung-Te Lin hungte@chromium.org
Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Nicolas Boichat drinkcat@chromium.org
Gerrit-Reviewer: You-Cheng Syu youcheng@google.com
Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Reviewer: jitao shi jitao.shi@mediatek.com
Gerrit-Reviewer: yongqiang niu yongqiang.niu@mediatek.com
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 09 Aug 2019 18:05:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
1933
days inactive
1933
days old
0 comments
1 participants
participants (1)
-
Julius Werner (Code Review)