[S] Change in coreboot[main]: soc/intel/common/block/acpi: Add GPE1 blocks to ACPI FADT table - coreboot-gerrit

9 Sep 2024


      Attention is currently required from: Cliff Huang.
Felix Held has posted comments on this change by Cliff Huang. ( https://review.coreboot.org/c/coreboot/+/84103?usp=email )
Change subject: soc/intel/common/block/acpi: Add GPE1 blocks to ACPI FADT table
......................................................................
Patch Set 15:
(1 comment)
File src/soc/intel/common/block/acpi/acpi.c:
https://review.coreboot.org/c/coreboot/+/84103/comment/f0a82554_c1c0c50b?usp... :
PS15, Line 110: fadt->gpe1_blk = GPE1_STS(0) ? (pmbase + GPE1_STS(0)) : 0;
              : 	if (fadt->gpe1_blk) {
checking if CONFIG(SOC_INTEL_COMMON_BLOCK_ACPI_HAVE_GPE1) is true and if so setting the 3 values within that if block would make the code easier to read
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/84103?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia6928c35b86f4a2243d58597b17b2a3a5f54271e
Gerrit-Change-Number: 84103
Gerrit-PatchSet: 15
Gerrit-Owner: Cliff Huang cliff.huang@intel.com
Gerrit-Reviewer: Anil Kumar K anil.kumar.k@intel.com
Gerrit-Reviewer: Bora Guvendik bora.guvendik@intel.com
Gerrit-Reviewer: Subrata Banik subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: 9elements QA hardwaretestrobot@gmail.com
Gerrit-CC: Felix Held felix-coreboot@felixheld.de
Gerrit-CC: Hannah Williams hannah.williams@intel.com
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Cliff Huang cliff.huang@intel.com
Gerrit-Comment-Date: Mon, 09 Sep 2024 15:11:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No