Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34750 )
Change subject: Kconfig: remove CAR global migration when ramstage stage is used ......................................................................
Kconfig: remove CAR global migration when ramstage stage is used
When a platform is not using postcar stage (!HAVE_POSTCAR) it will use ramstage hence it's by definition not tearing down cache-as-ram from within romstage prior to loading ramstage. Because of this property there's no need to migrate CAR_GLOBAL variables to cbmem.
Change-Id: I9bd9c53ca2404b66445d4c558e1a4b151bc2fe41 Signed-off-by: Subrata Banik subrata.banik@intel.com --- M src/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/34750/1
diff --git a/src/Kconfig b/src/Kconfig index 2bb5bfe..62c2f0d 100644 --- a/src/Kconfig +++ b/src/Kconfig @@ -1208,3 +1208,4 @@ bool default n if RAMPAYLOAD default y + select NO_CAR_GLOBAL_MIGRATION if !HAVE_POSTCAR
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34750 )
Change subject: Kconfig: remove CAR global migration when ramstage stage is used ......................................................................
Patch Set 1: Code-Review-1
That isn't true for FSP1.0
Hello Patrick Rudolph, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/34750
to look at the new patch set (#2).
Change subject: Kconfig: remove CAR global migration when ramstage stage is used ......................................................................
Kconfig: remove CAR global migration when ramstage stage is used
When a platform is not using postcar stage (!HAVE_POSTCAR) it will use ramstage hence it's by definition not tearing down cache-as-ram from within romstage prior to loading ramstage. Because of this property there's no need to migrate CAR_GLOBAL variables to cbmem.
Change-Id: I9bd9c53ca2404b66445d4c558e1a4b151bc2fe41 Signed-off-by: Subrata Banik subrata.banik@intel.com --- M src/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/34750/2
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34750 )
Change subject: Kconfig: remove CAR global migration when ramstage stage is used ......................................................................
Patch Set 2:
Patch Set 1: Code-Review-1
That isn't true for FSP1.0
I don't see such dependency here on FSP1.0 ? https://github.com/coreboot/coreboot/blob/b8f1bd7a378dbc1fa5adfd557292aef10f...
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34750 )
Change subject: Kconfig: remove CAR global migration when ramstage stage is used ......................................................................
Patch Set 2: Code-Review-1
Patch Set 2:
Patch Set 1: Code-Review-1
That isn't true for FSP1.0
I don't see such dependency here on FSP1.0 ? https://github.com/coreboot/coreboot/blob/b8f1bd7a378dbc1fa5adfd557292aef10f...
It's unrelated to postcar.
Subrata Banik has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/34750 )
Change subject: Kconfig: remove CAR global migration when ramstage stage is used ......................................................................
Abandoned
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34750 )
Change subject: Kconfig: remove CAR global migration when ramstage stage is used ......................................................................
Patch Set 2:
Patch Set 2: Code-Review-1
Patch Set 2:
Patch Set 1: Code-Review-1
That isn't true for FSP1.0
I don't see such dependency here on FSP1.0 ? https://github.com/coreboot/coreboot/blob/b8f1bd7a378dbc1fa5adfd557292aef10f...
It's unrelated to postcar.
please read the commit msg, it has description why its been tied with !postcar. But i have realized there are old AMD platform that working without postcar migration hence selecting NO_CAR_GLOBAL_MIGRATION based on !postcar might force them to discontinue CAR global migration, which might not be right, hence abandon this CL and migrating this selection to required soc