Attention is currently required from: Arthur Heymans, Arthur Heymans, Benjamin Doron, Felix Singer.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75886?usp=email )
Change subject: arch/x86,lib: Migrate SMBIOS implementation to common code
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
File src/include/smbios.h:
https://review.coreboot.org/c/coreboot/+/75886/comment/78b9909d_778a62cc :
PS3, Line 15: } while (0)
NB. The one call in x86 code seems quite ugly. Maybe we could refactor
this later so the macro stays private to the common `smbios.c`.
Random thought about this, I'd probably make it a simpler function,
`size_t update_max(size_t *max_len, size_t len)`. So that the code
can be written more obvious, e.g.
```
len += update_max(&max_struct_size, smbios_write...
```
Nothing to do right now.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75886?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I030c853f83f8427da4a4c661b82a6487938b24e6
Gerrit-Change-Number: 75886
Gerrit-PatchSet: 3
Gerrit-Owner: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-Attention: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Wed, 21 Jun 2023 12:52:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment