Maxim Polyakov has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44474 )
Change subject: util/intelp2m: Remove unnecessary tabs ......................................................................
util/intelp2m: Remove unnecessary tabs
Change-Id: I5aa4b9ac4fa1ceb6f3c2ade214d47b29246ece55 Signed-off-by: Maxim Polyakov max.senia.poliak@gmail.com --- M util/intelp2m/parser/template.go 1 file changed, 4 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/44474/1
diff --git a/util/intelp2m/parser/template.go b/util/intelp2m/parser/template.go index bc7d702..3248152 100644 --- a/util/intelp2m/parser/template.go +++ b/util/intelp2m/parser/template.go @@ -123,10 +123,10 @@ // 0x0088: 0x00ffffff (HOSTSW_OWN_GPP_F) // 0x0100: 0x00000000 (GPI_IS_GPP_A) if fields := strings.FieldsFunc(line, tokenCheck); len(fields) == 3 { - *name = fields[2] - fmt.Sscanf(fields[1], "0x%x", value) - fmt.Sscanf(fields[0], "0x%x", offset) - return 0 + *name = fields[2] + fmt.Sscanf(fields[1], "0x%x", value) + fmt.Sscanf(fields[0], "0x%x", offset) + return 0 } return -1 }
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44474 )
Change subject: util/intelp2m: Remove unnecessary tabs ......................................................................
Patch Set 2: Code-Review+2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44474 )
Change subject: util/intelp2m: Remove unnecessary tabs ......................................................................
Patch Set 2: Code-Review+2
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44474 )
Change subject: util/intelp2m: Remove unnecessary tabs ......................................................................
Patch Set 2: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/44474 )
Change subject: util/intelp2m: Remove unnecessary tabs ......................................................................
util/intelp2m: Remove unnecessary tabs
Change-Id: I5aa4b9ac4fa1ceb6f3c2ade214d47b29246ece55 Signed-off-by: Maxim Polyakov max.senia.poliak@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/44474 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Matt DeVillier matt.devillier@gmail.com Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Michael Niewöhner foss@mniewoehner.de --- M util/intelp2m/parser/template.go 1 file changed, 4 insertions(+), 4 deletions(-)
Approvals: build bot (Jenkins): Verified Matt DeVillier: Looks good to me, approved Angel Pons: Looks good to me, approved Michael Niewöhner: Looks good to me, approved
diff --git a/util/intelp2m/parser/template.go b/util/intelp2m/parser/template.go index bc7d702..3248152 100644 --- a/util/intelp2m/parser/template.go +++ b/util/intelp2m/parser/template.go @@ -123,10 +123,10 @@ // 0x0088: 0x00ffffff (HOSTSW_OWN_GPP_F) // 0x0100: 0x00000000 (GPI_IS_GPP_A) if fields := strings.FieldsFunc(line, tokenCheck); len(fields) == 3 { - *name = fields[2] - fmt.Sscanf(fields[1], "0x%x", value) - fmt.Sscanf(fields[0], "0x%x", offset) - return 0 + *name = fields[2] + fmt.Sscanf(fields[1], "0x%x", value) + fmt.Sscanf(fields[0], "0x%x", offset) + return 0 } return -1 }