Attention is currently required from: Felix Singer, Henry Sun, Kangheui Won, Reka Norman, Simon Yang, Tarun Tuli, Yunlong Jia.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75872?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: mb/google/nissa/var/gothrax: Add GPIO table for gothrax
......................................................................
Patch Set 7:
(3 comments)
Patchset:
PS7:
Please remember check the include header all the time 👍
File src/mainboard/google/brya/variants/gothrax/gpio.c:
https://review.coreboot.org/c/coreboot/+/75872/comment/cd351024_dbbe7c35 :
PS7, Line 3: #include <baseboard/gpio.h>
not used. remove.
https://review.coreboot.org/c/coreboot/+/75872/comment/1e8ebc4f_17c93541 :
PS7, Line 5: #include <commonlib/helpers.h>
not used. remove.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75872?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If852c7a30edb9fb778872414cb15dc3446aebc55
Gerrit-Change-Number: 75872
Gerrit-PatchSet: 7
Gerrit-Owner: Yunlong Jia
yunlong.jia@ecs.corp-partner.google.com
Gerrit-Reviewer: Derek Huang
derekhuang@google.com
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Reka Norman
rekanorman@chromium.org
Gerrit-Reviewer: Simon Yang
simon1.yang@intel.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-CC: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-CC: Shou-Chieh Hsu
shouchieh@google.com
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Henry Sun
henrysun@google.com
Gerrit-Attention: Kangheui Won
khwon@chromium.org
Gerrit-Attention: Yunlong Jia
yunlong.jia@ecs.corp-partner.google.com
Gerrit-Attention: Reka Norman
rekanorman@chromium.org
Gerrit-Attention: Simon Yang
simon1.yang@intel.com
Gerrit-Comment-Date: Tue, 27 Jun 2023 01:11:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment