Attention is currently required from: Nico Huber, Julius Werner, Arthur Heymans.
Maximilian Brune has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68160 )
Change subject: util/cbfstool: Add a new mechanism to provide a memory mapped
......................................................................
Patch Set 4:
(1 comment)
File src/soc/intel/common/block/fast_spi/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/68160/comment/0cb4959e_21379cac
PS4, Line 91: FLASH_BIOS_BASE
nit: I find the naming here a bit confusing, it took me too long to figure out that "BIOS" and "EXT_ […]
If anything I would use your first suggestion. Using obscure naming schemes like 'DEFAULT' only makes an 'use either default or extended values' impression to me.
Although considering the code comment above, I think it's more or less clear what the values mean.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68160
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I38ab4c369704497f711e14ecda3ff3a8cdc0d089
Gerrit-Change-Number: 68160
Gerrit-PatchSet: 4
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Sat, 05 Nov 2022 19:07:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment