Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36533 )
Change subject: drivers/pc80: Remove UDELAY_IO ......................................................................
drivers/pc80: Remove UDELAY_IO
Change-Id: I3ab62d9b1caa23305ad3b859e3c1949784ae0464 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/drivers/pc80/pc/Kconfig M src/drivers/pc80/pc/Makefile.inc D src/drivers/pc80/pc/udelay_io.c 3 files changed, 0 insertions(+), 33 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/36533/1
diff --git a/src/drivers/pc80/pc/Kconfig b/src/drivers/pc80/pc/Kconfig index bba45f6..06e6568 100644 --- a/src/drivers/pc80/pc/Kconfig +++ b/src/drivers/pc80/pc/Kconfig @@ -18,10 +18,6 @@ this option, then you can say N here to speed up boot time. Otherwise say Y.
-config UDELAY_IO - bool - default n - # This option is used in code but never selected. config UDELAY_TIMER2 bool diff --git a/src/drivers/pc80/pc/Makefile.inc b/src/drivers/pc80/pc/Makefile.inc index bd56cd4..67c40a1 100644 --- a/src/drivers/pc80/pc/Makefile.inc +++ b/src/drivers/pc80/pc/Makefile.inc @@ -2,8 +2,6 @@
ramstage-y += isa-dma.c ramstage-y += i8259.c -ramstage-$(CONFIG_UDELAY_IO) += udelay_io.c -romstage-$(CONFIG_UDELAY_IO) += udelay_io.c ramstage-y += keyboard.c ramstage-$(CONFIG_SPKMODEM) += spkmodem.c romstage-$(CONFIG_SPKMODEM) += spkmodem.c diff --git a/src/drivers/pc80/pc/udelay_io.c b/src/drivers/pc80/pc/udelay_io.c deleted file mode 100644 index 4fe1cae..0000000 --- a/src/drivers/pc80/pc/udelay_io.c +++ /dev/null @@ -1,27 +0,0 @@ -/* - * This file is part of the coreboot project. - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; version 2 of the License. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - */ - -#include <arch/io.h> -#include <delay.h> - -void init_timer(void) -{ -} - -void udelay(unsigned int usecs) -{ - int i; - - for (i = 0; i < usecs; i++) - inb(0x80); -}
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36533 )
Change subject: drivers/pc80: Remove UDELAY_IO ......................................................................
Patch Set 1: Code-Review+2
Kyösti Mälkki has submitted this change. ( https://review.coreboot.org/c/coreboot/+/36533 )
Change subject: drivers/pc80: Remove UDELAY_IO ......................................................................
drivers/pc80: Remove UDELAY_IO
Change-Id: I3ab62d9b1caa23305ad3b859e3c1949784ae0464 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/36533 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Patrick Rudolph siro@das-labor.org --- M src/drivers/pc80/pc/Kconfig M src/drivers/pc80/pc/Makefile.inc D src/drivers/pc80/pc/udelay_io.c 3 files changed, 0 insertions(+), 33 deletions(-)
Approvals: build bot (Jenkins): Verified Patrick Rudolph: Looks good to me, approved
diff --git a/src/drivers/pc80/pc/Kconfig b/src/drivers/pc80/pc/Kconfig index bba45f6..06e6568 100644 --- a/src/drivers/pc80/pc/Kconfig +++ b/src/drivers/pc80/pc/Kconfig @@ -18,10 +18,6 @@ this option, then you can say N here to speed up boot time. Otherwise say Y.
-config UDELAY_IO - bool - default n - # This option is used in code but never selected. config UDELAY_TIMER2 bool diff --git a/src/drivers/pc80/pc/Makefile.inc b/src/drivers/pc80/pc/Makefile.inc index bd56cd4..67c40a1 100644 --- a/src/drivers/pc80/pc/Makefile.inc +++ b/src/drivers/pc80/pc/Makefile.inc @@ -2,8 +2,6 @@
ramstage-y += isa-dma.c ramstage-y += i8259.c -ramstage-$(CONFIG_UDELAY_IO) += udelay_io.c -romstage-$(CONFIG_UDELAY_IO) += udelay_io.c ramstage-y += keyboard.c ramstage-$(CONFIG_SPKMODEM) += spkmodem.c romstage-$(CONFIG_SPKMODEM) += spkmodem.c diff --git a/src/drivers/pc80/pc/udelay_io.c b/src/drivers/pc80/pc/udelay_io.c deleted file mode 100644 index 4fe1cae..0000000 --- a/src/drivers/pc80/pc/udelay_io.c +++ /dev/null @@ -1,27 +0,0 @@ -/* - * This file is part of the coreboot project. - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; version 2 of the License. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - */ - -#include <arch/io.h> -#include <delay.h> - -void init_timer(void) -{ -} - -void udelay(unsigned int usecs) -{ - int i; - - for (i = 0; i < usecs; i++) - inb(0x80); -}
-
Kyösti Mälkki (Code Review) -
Patrick Rudolph (Code Review)