Attention is currently required from: Martin L Roth, Raul Rangel, Rob Barnes.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76188?usp=email )
Change subject: util/apcb: Add apcb edit tool for phoenix ......................................................................
Patch Set 2:
(1 comment)
File util/apcb/apcb_v3a_edit.py:
https://review.coreboot.org/c/coreboot/+/76188/comment/2b581c41_06dd56be : PS2, Line 35: parser.add_argument( : '--mem_type', : type=str, : default='lp5', : help='Memory type [lp5|lp5x]. Default = lp5') Not required. In previous versions of tool, we used it to choose the starting pattern for SPD and it varied based on memory technology.
Here the starting pattern for SPD (SPD_ENTRY_MAGIC) is not related to memory technology. Hence can be removed.
Also we are not using this option in the rest of the code.