Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45730 )
Change subject: arch/x86: Introduce `ARCH_ALL_STAGES_X86_64` ......................................................................
arch/x86: Introduce `ARCH_ALL_STAGES_X86_64`
Though only one platform uses it, this will save some redundancy.
Change-Id: Ic151efe5dd9b7c89f779ac3e10c3a045f07221d3 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/arch/x86/Kconfig M src/cpu/qemu-x86/Kconfig 2 files changed, 8 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/45730/1
diff --git a/src/arch/x86/Kconfig b/src/arch/x86/Kconfig index d906436..14f542a 100644 --- a/src/arch/x86/Kconfig +++ b/src/arch/x86/Kconfig @@ -50,6 +50,13 @@ bool select ARCH_X86
+config ARCH_ALL_STAGES_X86_64 + bool + select ARCH_BOOTBLOCK_X86_64 + select ARCH_VERSTAGE_X86_64 + select ARCH_ROMSTAGE_X86_64 + select ARCH_RAMSTAGE_X86_64 + if ARCH_X86
config ARCH_X86_64_PGTBL_LOC diff --git a/src/cpu/qemu-x86/Kconfig b/src/cpu/qemu-x86/Kconfig index af0c746..e72fbc3 100644 --- a/src/cpu/qemu-x86/Kconfig +++ b/src/cpu/qemu-x86/Kconfig @@ -12,11 +12,8 @@
config CPU_QEMU_X86_64 bool "Experimental 64bit support" - select ARCH_BOOTBLOCK_X86_64 - select ARCH_VERSTAGE_X86_64 - select ARCH_ROMSTAGE_X86_64 + select ARCH_ALL_STAGES_X86_64 select ARCH_POSTCAR_X86_64 - select ARCH_RAMSTAGE_X86_64
config CPU_QEMU_X86_32 bool
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45730 )
Change subject: arch/x86: Introduce `ARCH_ALL_STAGES_X86_64` ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45730/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45730/1//COMMIT_MSG@10 PS1, Line 10: Why is postcar stage left out?
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45730 )
Change subject: arch/x86: Introduce `ARCH_ALL_STAGES_X86_64` ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45730/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45730/1//COMMIT_MSG@10 PS1, Line 10:
Why is postcar stage left out?
See arch/x86/Kconfig. It is already set to the same x86 arch for platforms with POSTCAR_STAGE. Also, what prompted this change is CB:45699 and postcar isn't selected there.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45730 )
Change subject: arch/x86: Introduce `ARCH_ALL_STAGES_X86_64` ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/45730/1/src/cpu/qemu-x86/Kconfig File src/cpu/qemu-x86/Kconfig:
https://review.coreboot.org/c/coreboot/+/45730/1/src/cpu/qemu-x86/Kconfig@16 PS1, Line 16: select ARCH_POSTCAR_X86_64 So this is redundant and could be fixed later?
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45730 )
Change subject: arch/x86: Introduce `ARCH_ALL_STAGES_X86_64` ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45730/1/src/cpu/qemu-x86/Kconfig File src/cpu/qemu-x86/Kconfig:
https://review.coreboot.org/c/coreboot/+/45730/1/src/cpu/qemu-x86/Kconfig@16 PS1, Line 16: select ARCH_POSTCAR_X86_64
So this is redundant and could be fixed later?
Ah, POSTCAR_STAGE defaults to y. I'll clean up all instances.
Nico Huber has submitted this change. ( https://review.coreboot.org/c/coreboot/+/45730 )
Change subject: arch/x86: Introduce `ARCH_ALL_STAGES_X86_64` ......................................................................
arch/x86: Introduce `ARCH_ALL_STAGES_X86_64`
Though only one platform uses it, this will save some redundancy.
Change-Id: Ic151efe5dd9b7c89f779ac3e10c3a045f07221d3 Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/45730 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Nico Huber nico.h@gmx.de --- M src/arch/x86/Kconfig M src/cpu/qemu-x86/Kconfig 2 files changed, 8 insertions(+), 4 deletions(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved
diff --git a/src/arch/x86/Kconfig b/src/arch/x86/Kconfig index d906436..14f542a 100644 --- a/src/arch/x86/Kconfig +++ b/src/arch/x86/Kconfig @@ -50,6 +50,13 @@ bool select ARCH_X86
+config ARCH_ALL_STAGES_X86_64 + bool + select ARCH_BOOTBLOCK_X86_64 + select ARCH_VERSTAGE_X86_64 + select ARCH_ROMSTAGE_X86_64 + select ARCH_RAMSTAGE_X86_64 + if ARCH_X86
config ARCH_X86_64_PGTBL_LOC diff --git a/src/cpu/qemu-x86/Kconfig b/src/cpu/qemu-x86/Kconfig index af0c746..e72fbc3 100644 --- a/src/cpu/qemu-x86/Kconfig +++ b/src/cpu/qemu-x86/Kconfig @@ -12,11 +12,8 @@
config CPU_QEMU_X86_64 bool "Experimental 64bit support" - select ARCH_BOOTBLOCK_X86_64 - select ARCH_VERSTAGE_X86_64 - select ARCH_ROMSTAGE_X86_64 + select ARCH_ALL_STAGES_X86_64 select ARCH_POSTCAR_X86_64 - select ARCH_RAMSTAGE_X86_64
config CPU_QEMU_X86_32 bool
-
Angel Pons (Code Review) -
Nico Huber (Code Review)
-
Paul Menzel (Code Review)