Attention is currently required from: Subrata Banik, Tim Wawrzynczak, Patrick Rudolph. Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62560 )
Change subject: soc/intel/common: Retry MEI CSE DISABLE command ......................................................................
Patch Set 3:
(3 comments)
File src/soc/intel/common/block/cse/cse_eop.c:
https://review.coreboot.org/c/coreboot/+/62560/comment/1f4f1aa9_de2977ff PS3, Line 14: MAX_RETRY_EOP_MSG
does it make sense to create enum as below, you can make this flexible to add short or long retry co […]
Hmm :) I don't think this will be required!
https://review.coreboot.org/c/coreboot/+/62560/comment/895d2050_5d137a59 PS3, Line 31: decode_heci_send_receive_error
how this function is different than decode_eop_error() below? […]
Since EOP command handler returns cse_eop_result type enum values while CSE DISABLE command handler use generic cse_cmd_result enum values. hence, I used separate function for the same action. By using unified enum values for EOP and CSE DISABLE command handlers, then we can use common function that can be used for the both command handlers.
https://review.coreboot.org/c/coreboot/+/62560/comment/29fabb92_12438148 PS3, Line 77: cse_send_bus_disable_message
it's almost same as cse_send_end_of_post_message() […]
See above reason. Both handlers use own enum values, so APIs return different enum type values. Hence, separate function is used. We can use common function by implementing the unified enum type values.
-
Sridhar Siricilla (Code Review)