Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60771 )
Change subject: soc/amd/common/block/include/lpc: add comment about RANGE_UNIT values ......................................................................
soc/amd/common/block/include/lpc: add comment about RANGE_UNIT values
Signed-off-by: Felix Held felix-coreboot@felixheld.de Change-Id: I22f3485ec81f76af7e0e96b7c1271d5ccf52e701 --- M src/soc/amd/common/block/include/amdblocks/lpc.h 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/60771/1
diff --git a/src/soc/amd/common/block/include/amdblocks/lpc.h b/src/soc/amd/common/block/include/amdblocks/lpc.h index 173cbd1..558b608 100644 --- a/src/soc/amd/common/block/include/amdblocks/lpc.h +++ b/src/soc/amd/common/block/include/amdblocks/lpc.h @@ -74,7 +74,7 @@ #define ROM_BASE_MASK 0xfffff000 /* bits 31-12 */ #define ROM_RANGE_WP BIT(10) #define ROM_RANGE_RP BIT(9) -#define RANGE_UNIT BIT(8) +#define RANGE_UNIT BIT(8) /* 0: 4kiB, 1: 64kiB */ #define RANGE_ADDR_MASK 0x000000ff /* Range defined by bits 7-0 */ #define ROM_PROTECT_RANGE_REG(n) (ROM_PROTECT_RANGE0 + (4 * n)) #define MAX_ROM_PROTECT_RANGES 4