Patrick Georgi (pgeorgi@google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/18036
-gerrit
commit fbf9c68038109be671f7be3c3933c630f2c19d24 Author: Patrick Georgi pgeorgi@chromium.org Date: Wed Jan 4 22:22:56 2017 +0100
libpayload: usb: handle situation with no free device address
Change-Id: I1308bdca90f1a09d980f384ee85552198a39b965 Signed-off-by: Patrick Georgi pgeorgi@chromium.org Found-by: Coverity Scan #1260940 --- payloads/libpayload/drivers/usb/usb.c | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/payloads/libpayload/drivers/usb/usb.c b/payloads/libpayload/drivers/usb/usb.c index bfb697d..bb42f89 100644 --- a/payloads/libpayload/drivers/usb/usb.c +++ b/payloads/libpayload/drivers/usb/usb.c @@ -336,6 +336,8 @@ generic_set_address (hci_t *controller, usb_speed speed, int hubport, int hubaddr) { int adr = get_free_address (controller); // address to set + if (adr < 0) + return NULL; dev_req_t dr;
memset (&dr, 0, sizeof (dr));