Attention is currently required from: Felix Singer, Michał Żygowski, Tim Wawrzynczak, Michał Kopeć, Angel Pons, Arthur Heymans.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68791 )
Change subject: ec/clevo/it5570e: add driver for EC used on various Clevo laptops ......................................................................
Patch Set 6:
(9 comments)
Commit Message:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-161716): https://review.coreboot.org/c/coreboot/+/68791/comment/5056ba15_805b6d77 PS6, Line 56: Signed-off-by: Michał Kopeć michal.kopec@3mdeb.com Non-standard signature: Co-authored-by:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-161716): https://review.coreboot.org/c/coreboot/+/68791/comment/ca0a754d_6f6e2453 PS6, Line 57: Signed-off-by: Michał Żygowski michal.zygowski@3mdeb.com Non-standard signature: Co-authored-by:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-161716): https://review.coreboot.org/c/coreboot/+/68791/comment/a42f89fe_a2967ec4 PS6, Line 58: Signed-off-by: Michael Niewöhner foss@mniewoehner.de Non-standard signature: Co-authored-by:
File src/ec/clevo/it5570e/commands.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-161716): https://review.coreboot.org/c/coreboot/+/68791/comment/86552337_51508e2e PS6, Line 44: while (recv_ec_data() != '$'); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-161716): https://review.coreboot.org/c/coreboot/+/68791/comment/22ed6ce1_b2dc92c7 PS6, Line 119: else if (start > 100 || stop > 100) { else should follow close brace '}'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-161716): https://review.coreboot.org/c/coreboot/+/68791/comment/e51a0e9c_7525a9be PS6, Line 122: else if (start >= stop) { else should follow close brace '}'
File src/ec/clevo/it5570e/ec.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-161716): https://review.coreboot.org/c/coreboot/+/68791/comment/759bdb8a_ee39d936 PS6, Line 123: if (dev->path.type == DEVICE_PATH_GENERIC && dev->path.generic.id == 0) { braces {} are not necessary for any arm of this statement
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-161716): https://review.coreboot.org/c/coreboot/+/68791/comment/467ac5af_76d7e178 PS6, Line 126: else { else should follow close brace '}'
File src/ec/clevo/it5570e/ssdt.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-161716): https://review.coreboot.org/c/coreboot/+/68791/comment/b1ab3089_9c29ecb6 PS6, Line 139: for (int i = 0; i < fan_cnt; i++) { braces {} are not necessary for single statement blocks