Attention is currently required from: Felix Held, Julius Werner, Lean Sheng Tan, Matt DeVillier, Maximilian Brune, Philipp Hug, ron minnich.
Benjamin Doron has posted comments on this change by Benjamin Doron. ( https://review.coreboot.org/c/coreboot/+/84796?usp=email )
Change subject: lib/{fit,fit_payload}.c: Enhance support for FIT images
......................................................................
Patch Set 9:
(2 comments)
File src/lib/fit.c:
https://review.coreboot.org/c/coreboot/+/84796/comment/0b52f1c0_b57c2632?usp... :
PS4, Line 523: }
True, and the current solution runs into the issue of how images could have clashing load addresses, […]
Simon Glass told me elsewhere that `loadables` in the config node is the supported way to do this. So, I'll make that change in EDK2, edit the code that gather the secondary_images, and then this is done. Alternatively, we should at least mark this as a comment in the code.
File src/lib/fit.c:
https://review.coreboot.org/c/coreboot/+/84796/comment/cfa235dd_b5c389d8?usp... :
PS6, Line 119: if (!strcmp("data-offset", prop->prop.name))
nit: IIRC coding style says that if one if-else branch has curly braces, all of them must use them ( […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84796?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I6a21954c0dc5fd820d135e8cd0599ce87903a1c0
Gerrit-Change-Number: 84796
Gerrit-PatchSet: 9
Gerrit-Owner: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Lean Sheng Tan
tanleansheng@outlook.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: Philipp Hug
philipp@hug.cx
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-Attention: Philipp Hug
philipp@hug.cx
Gerrit-Attention: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Attention: Lean Sheng Tan
tanleansheng@outlook.com
Gerrit-Attention: ron minnich
rminnich@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Thu, 26 Dec 2024 20:10:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Benjamin Doron
benjamin.doron00@gmail.com
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org